From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: Jiri Kosina <jkosina@suse.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-input <linux-input@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: i2c-HID: Delete unnecessary checks before the function call "gpiod_put"
Date: Thu, 9 Jul 2015 23:10:16 +0200 [thread overview]
Message-ID: <559EE338.4060107@users.sourceforge.net> (raw)
In-Reply-To: <CAN+gG=G9xiFUDML6i44mKodW4tiQPgGQ0Ft7oV8RA1JpuuQ1KQ@mail.gmail.com>
>> The proposed update candidates are contained in the source
>> file "drivers/hid/i2c-hid/i2c-hid.c" from Linux next-20150708.
>>
>> * i2c_hid_remove() function:
>> Can it be tolerated here that the pointer "ihid->desc" might be eventually null?
>>
>> * i2c_hid_probe() function:
>> Is this implementation structured in such a way that a pointer for valid data
>> will be usually passed for "ihid->desc" if the statements after the jump
>> label "err" will be reached?
>>
>
> Again, in both case it is completely normal to have "ihid->desc ==
> NULL" given that this field is only retrieved in case of an ACPI
> device which does not declares an IRQ but a GPIO. Most ACPI devices I
> saw are using a simple IRQ, and the OF instantiations of the driver
> will definitively have ihid->desc null. So I do not want to have a
> warning for most of i2c-hid devices out there (because I will have to
> explain that this is completely normal again and again).
Would it make sense to annotate checks before such function calls
as "unlikely" then?
Regards,
Markus
next prev parent reply other threads:[~2015-07-09 21:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5307CAA2.8060406@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
[not found] ` <530A086E.8010901@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
[not found] ` <530A72AA.3000601@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
[not found] ` <530B5FB6.6010207@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
[not found] ` <530C5E18.1020800@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
[not found] ` <530CD2C4.4050903@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
[not found] ` <530CF8FF.8080600@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
[not found] ` <530DD06F.4090703@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
[not found] ` <5317A59D.4@users.so urceforge.net>
[not found] ` <5317A59D.4@users.sourceforge.net>
2014-11-19 17:38 ` [PATCH 1/1] HID-picoLCD: Deletion of unnecessary checks before three function calls SF Markus Elfring
2015-06-28 11:54 ` [PATCH] " SF Markus Elfring
2015-06-29 6:34 ` Bruno Prémont
2015-06-29 12:05 ` Jiri Kosina
2014-11-29 14:33 ` [PATCH 1/1] HID: Wacom: Deletion of unnecessary checks before the function call "input_free_device" SF Markus Elfring
2015-07-09 6:08 ` [PATCH v2] HID: Wacom: Delete " SF Markus Elfring
2015-07-09 12:28 ` Jiri Kosina
2015-02-05 16:40 ` [PATCH] Input: Delete an unnecessary check " SF Markus Elfring
2015-02-11 18:11 ` Dmitry Torokhov
2015-07-08 20:30 ` [PATCH] i2c-HID: Delete unnecessary checks before the function call "gpiod_put" SF Markus Elfring
2015-07-09 8:18 ` Dan Carpenter
2015-07-09 12:34 ` Jiri Kosina
2015-07-09 18:38 ` Benjamin Tissoires
2015-07-09 20:49 ` SF Markus Elfring
2015-07-09 20:56 ` Benjamin Tissoires
2015-07-09 21:10 ` SF Markus Elfring [this message]
2015-07-09 21:21 ` Benjamin Tissoires
2015-11-06 17:00 ` [PATCH] HID: Wacom: Delete an unnecessary check before the function call "kobject_put" SF Markus Elfring
2015-11-19 15:53 ` Jiri Kosina
2016-07-24 7:35 ` [PATCH] Input-rmi_bus: Delete an unnecessary check before the function call "of_node_put" SF Markus Elfring
2016-07-25 18:30 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559EE338.4060107@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=benjamin.tissoires@gmail.com \
--cc=jkosina@suse.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).