From: Lars-Peter Clausen <lars@metafoo.de>
To: Alban Bedel <albeu@free.fr>, linux-mips@linux-mips.org
Cc: "Ralf Baechle" <ralf@linux-mips.org>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Tejun Heo" <tj@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Florian Fainelli" <florian@openwrt.org>,
"Joe Perches" <joe@perches.com>,
"Daniel Walter" <dwalter@google.com>,
"Sergey Ryazanov" <ryazanov.s.a@gmail.com>,
"Huacai Chen" <chenhc@lemote.com>,
"Andrew Bresticker" <abrestic@chromium.org>,
"James Hartley" <james.hartley@imgtec.com>,
"Paul Burton" <paul.burton@imgtec.com>,
"Waldemar Brodkorb" <wbx@openadk.org>,
"James Hogan" <james.hogan@imgtec.com>,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Levente Kurusa" <levex@linux.com>,
"abdoulaye berthe" <berthe.ab@gmail.com>,
"Wolfram Sang" <wsa@the-dreams.de>,
linux-kernel@vger
Subject: Re: [PATCH] MIPS: Remove most of the custom gpio.h
Date: Thu, 23 Jul 2015 20:25:53 +0200 [thread overview]
Message-ID: <55B131B1.10302@metafoo.de> (raw)
In-Reply-To: <1437586416-14735-1-git-send-email-albeu@free.fr>
On 07/22/2015 07:33 PM, Alban Bedel wrote:
> diff --git a/arch/mips/jz4740/gpio.c b/arch/mips/jz4740/gpio.c
> index 54c80d4..3dc500c 100644
> --- a/arch/mips/jz4740/gpio.c
> +++ b/arch/mips/jz4740/gpio.c
> @@ -262,18 +262,6 @@ uint32_t jz_gpio_port_get_value(int port, uint32_t mask)
> }
> EXPORT_SYMBOL(jz_gpio_port_get_value);
>
> -int gpio_to_irq(unsigned gpio)
> -{
> - return JZ4740_IRQ_GPIO(0) + gpio;
> -}
> -EXPORT_SYMBOL_GPL(gpio_to_irq);
This need to be hooked up the gpio_to_irq() callback of the gpio_chip struct
of this driver rather than completely removing it. Otherwise this
functionality will be broken.
Similar for other platforms which implement the function.
- Lars
next prev parent reply other threads:[~2015-07-23 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 17:33 [PATCH] MIPS: Remove most of the custom gpio.h Alban Bedel
2015-07-22 17:47 ` Manuel Lauss
2015-07-23 8:40 ` Alban
2015-07-23 13:03 ` Linus Walleij
2015-07-23 18:25 ` Lars-Peter Clausen [this message]
2015-07-27 13:20 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B131B1.10302@metafoo.de \
--to=lars@metafoo.de \
--cc=abrestic@chromium.org \
--cc=albeu@free.fr \
--cc=b.zolnierkie@samsung.com \
--cc=berthe.ab@gmail.com \
--cc=chenhc@lemote.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwalter@google.com \
--cc=florian@openwrt.org \
--cc=gnurou@gmail.com \
--cc=hauke@hauke-m.de \
--cc=james.hartley@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=joe@perches.com \
--cc=levex@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=ryazanov.s.a@gmail.com \
--cc=tj@kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=wbx@openadk.org \
--cc=wsa@the-dreams.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).