From: Pingbo Wen <pingbo.wen@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: at32psif: handle clk_enable return value
Date: Fri, 11 Sep 2015 11:21:55 +0800 [thread overview]
Message-ID: <55F248D3.1090804@linaro.org> (raw)
In-Reply-To: <CAOMZO5C_JSsZY=J9a_+Co2+AYeV0HGPDGy-Z5EBBDmKmjgmSjA@mail.gmail.com>
On Friday, September 11, 2015 11:10 AM, Fabio Estevam wrote:
> On Fri, Sep 11, 2015 at 12:02 AM, WEN Pingbo <pingbo.wen@linaro.org> wrote:
>
>> - clk_enable(psif->pclk);
>> + retval = clk_enable(psif->pclk);
>> + if (retval < 0)
>> + dev_err(&psif->pdev->dev,
>> + "could not enable pclk, ret %d\n", retval);
> Shouldn't you add a 'return' here to prevent the code to proceed with
> the failed clock?
Yes, it should be there. I will re-send the patch. Thank you.
next prev parent reply other threads:[~2015-09-11 3:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 3:02 [PATCH 1/2] Input: at32psif: handle clk_enable return value WEN Pingbo
2015-09-11 3:02 ` [PATCH 2/2] Input: lpc32xx: " WEN Pingbo
2015-09-11 3:10 ` [PATCH 1/2] Input: at32psif: " Fabio Estevam
2015-09-11 3:21 ` Pingbo Wen [this message]
2015-09-11 3:34 ` [PATCH V2 " WEN Pingbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F248D3.1090804@linaro.org \
--to=pingbo.wen@linaro.org \
--cc=broonie@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).