* [PATCH 03/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag [not found] <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> @ 2015-09-21 15:46 ` Sudeep Holla 2015-10-05 5:44 ` Thierry Reding 2015-10-05 10:24 ` Laxman Dewangan 0 siblings, 2 replies; 5+ messages in thread From: Sudeep Holla @ 2015-09-21 15:46 UTC (permalink / raw) To: linux-pm, linux-kernel Cc: Sudeep Holla, Thomas Gleixner, Rafael J. Wysocki, Laxman Dewangan, Stephen Warren, Thierry Reding, linux-input, linux-tegra The driver handles wakeup irq correctly using device_init_wakeup and enable_irq_wake. There's no need to use IRQF_NO_SUSPEND while registering the interrupt. This patch removes the use of IRQF_NO_SUSPEND flag. Cc: Laxman Dewangan <ldewangan@nvidia.com> Cc: Stephen Warren <swarren@wwwdotorg.org> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: linux-input@vger.kernel.org Cc: linux-tegra@vger.kernel.org Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/input/keyboard/tegra-kbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c index f97c73bd14f8..5f5dbbd51991 100644 --- a/drivers/input/keyboard/tegra-kbc.c +++ b/drivers/input/keyboard/tegra-kbc.c @@ -705,7 +705,7 @@ static int tegra_kbc_probe(struct platform_device *pdev) input_set_drvdata(kbc->idev, kbc); err = devm_request_irq(&pdev->dev, kbc->irq, tegra_kbc_isr, - IRQF_NO_SUSPEND | IRQF_TRIGGER_HIGH, pdev->name, kbc); + IRQF_TRIGGER_HIGH, pdev->name, kbc); if (err) { dev_err(&pdev->dev, "failed to request keyboard IRQ\n"); return err; -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 03/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag 2015-09-21 15:46 ` [PATCH 03/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag Sudeep Holla @ 2015-10-05 5:44 ` Thierry Reding 2015-10-05 10:24 ` Laxman Dewangan 1 sibling, 0 replies; 5+ messages in thread From: Thierry Reding @ 2015-10-05 5:44 UTC (permalink / raw) To: Sudeep Holla Cc: linux-pm, linux-kernel, Thomas Gleixner, Rafael J. Wysocki, Laxman Dewangan, Stephen Warren, linux-input, linux-tegra [-- Attachment #1: Type: text/plain, Size: 710 bytes --] On Mon, Sep 21, 2015 at 04:46:59PM +0100, Sudeep Holla wrote: > The driver handles wakeup irq correctly using device_init_wakeup and > enable_irq_wake. There's no need to use IRQF_NO_SUSPEND while registering > the interrupt. > > This patch removes the use of IRQF_NO_SUSPEND flag. > > Cc: Laxman Dewangan <ldewangan@nvidia.com> > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: linux-input@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/input/keyboard/tegra-kbc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding <treding@nvidia.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 03/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag 2015-09-21 15:46 ` [PATCH 03/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag Sudeep Holla 2015-10-05 5:44 ` Thierry Reding @ 2015-10-05 10:24 ` Laxman Dewangan 2015-10-19 17:34 ` Sudeep Holla 1 sibling, 1 reply; 5+ messages in thread From: Laxman Dewangan @ 2015-10-05 10:24 UTC (permalink / raw) To: Sudeep Holla, linux-pm, linux-kernel Cc: Thomas Gleixner, Rafael J. Wysocki, Stephen Warren, Thierry Reding, linux-input, linux-tegra On Monday 21 September 2015 09:16 PM, Sudeep Holla wrote: > > diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c > index f97c73bd14f8..5f5dbbd51991 100644 > --- a/drivers/input/keyboard/tegra-kbc.c > +++ b/drivers/input/keyboard/tegra-kbc.c > @@ -705,7 +705,7 @@ static int tegra_kbc_probe(struct platform_device *pdev) > input_set_drvdata(kbc->idev, kbc); > > err = devm_request_irq(&pdev->dev, kbc->irq, tegra_kbc_isr, > - IRQF_NO_SUSPEND | IRQF_TRIGGER_HIGH, pdev->name, kbc); > + IRQF_TRIGGER_HIGH, pdev->name, kbc); > Acked-by: Laxman Dewangan <ldewangan@nvidia.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 03/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag 2015-10-05 10:24 ` Laxman Dewangan @ 2015-10-19 17:34 ` Sudeep Holla 2015-10-26 8:37 ` Dmitry Torokhov 0 siblings, 1 reply; 5+ messages in thread From: Sudeep Holla @ 2015-10-19 17:34 UTC (permalink / raw) To: linux-pm, linux-kernel, Dmitry Torokhov Cc: Laxman Dewangan, Sudeep Holla, Thomas Gleixner, Rafael J. Wysocki, Stephen Warren, Thierry Reding, linux-input, linux-tegra Hi Dmitry, On 05/10/15 11:24, Laxman Dewangan wrote: > > On Monday 21 September 2015 09:16 PM, Sudeep Holla wrote: >> >> diff --git a/drivers/input/keyboard/tegra-kbc.c >> b/drivers/input/keyboard/tegra-kbc.c >> index f97c73bd14f8..5f5dbbd51991 100644 >> --- a/drivers/input/keyboard/tegra-kbc.c >> +++ b/drivers/input/keyboard/tegra-kbc.c >> @@ -705,7 +705,7 @@ static int tegra_kbc_probe(struct platform_device >> *pdev) >> input_set_drvdata(kbc->idev, kbc); >> err = devm_request_irq(&pdev->dev, kbc->irq, tegra_kbc_isr, >> - IRQF_NO_SUSPEND | IRQF_TRIGGER_HIGH, pdev->name, kbc); >> + IRQF_TRIGGER_HIGH, pdev->name, kbc); >> > > Acked-by: Laxman Dewangan <ldewangan@nvidia.com> > Can you pick this up with all the Acks ? -- Regards, Sudeep ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 03/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag 2015-10-19 17:34 ` Sudeep Holla @ 2015-10-26 8:37 ` Dmitry Torokhov 0 siblings, 0 replies; 5+ messages in thread From: Dmitry Torokhov @ 2015-10-26 8:37 UTC (permalink / raw) To: Sudeep Holla Cc: linux-pm, linux-kernel, Laxman Dewangan, Thomas Gleixner, Rafael J. Wysocki, Stephen Warren, Thierry Reding, linux-input, linux-tegra On Mon, Oct 19, 2015 at 06:34:02PM +0100, Sudeep Holla wrote: > Hi Dmitry, > > On 05/10/15 11:24, Laxman Dewangan wrote: > > > >On Monday 21 September 2015 09:16 PM, Sudeep Holla wrote: > >> > >>diff --git a/drivers/input/keyboard/tegra-kbc.c > >>b/drivers/input/keyboard/tegra-kbc.c > >>index f97c73bd14f8..5f5dbbd51991 100644 > >>--- a/drivers/input/keyboard/tegra-kbc.c > >>+++ b/drivers/input/keyboard/tegra-kbc.c > >>@@ -705,7 +705,7 @@ static int tegra_kbc_probe(struct platform_device > >>*pdev) > >> input_set_drvdata(kbc->idev, kbc); > >> err = devm_request_irq(&pdev->dev, kbc->irq, tegra_kbc_isr, > >>- IRQF_NO_SUSPEND | IRQF_TRIGGER_HIGH, pdev->name, kbc); > >>+ IRQF_TRIGGER_HIGH, pdev->name, kbc); > >> > > > >Acked-by: Laxman Dewangan <ldewangan@nvidia.com> > > > > Can you pick this up with all the Acks ? Applied, thank you. -- Dmitry ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-26 8:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1442850433-5903-1-git-send-email-sudeep.holla@arm.com>
2015-09-21 15:46 ` [PATCH 03/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag Sudeep Holla
2015-10-05 5:44 ` Thierry Reding
2015-10-05 10:24 ` Laxman Dewangan
2015-10-19 17:34 ` Sudeep Holla
2015-10-26 8:37 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).