From: Gregor Riepl <onitake@gmail.com>
To: sergk sergk2mail <sergk.admin@gmail.com>, linux-input@vger.kernel.org
Subject: Re: How to setup Touchscreen IRQ mode?
Date: Mon, 21 Mar 2016 01:51:42 +0100 [thread overview]
Message-ID: <56EF459E.8000808@gmail.com> (raw)
In-Reply-To: <CA+V1LzrL6G1FJ6qXuTuiQQiMrZnj_QaHbGhFwBxpJrB9J=ZSGw@mail.gmail.com>
> err = request_irq(icn85xx_ts->irq, icn85xx_ts_interrupt,
> IRQ_TYPE_EDGE_FALLING, "icn85xx_ts", icn85xx_ts);
> if (err < 0){
> icn85xx_error("icn85xx_ts_probe: request irq failed\n");
> return err;
> }
>
> 1) Does this correct IRQ settings for TS? If not - what is procedure?
> What I have missed? H
I recommend using devm_request_threaded_irq instead.
The devm_* functions take care of deallocation automatically, and a threaded
IRQ handler is much better for slow operations like I2C access IMHO.
next prev parent reply other threads:[~2016-03-21 0:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 0:43 How to setup Touchscreen IRQ mode? sergk sergk2mail
2016-03-21 0:51 ` Gregor Riepl [this message]
2016-03-27 0:05 ` sergk sergk2mail
2016-03-29 9:52 ` Mika Westerberg
2016-03-29 12:52 ` sergk sergk2mail
[not found] ` <CA+V1LzqzMyxoAQv=DDFvWr_MOTThVnhJwTt8uS_piwVhGJtWgQ@mail.gmail.com>
[not found] ` <20160329125642.GM2099@lahna.fi.intel.com>
[not found] ` <CA+V1Lzov4WXXjERAwAV03VdMEQKDC_=ADAgr2-0p-k=gYC8i3w@mail.gmail.com>
[not found] ` <20160329133307.GO2099@lahna.fi.intel.com>
2016-03-30 0:03 ` sergk sergk2mail
2016-03-30 0:09 ` sergk sergk2mail
2016-03-30 9:41 ` Mika Westerberg
2016-03-30 10:28 ` sergk sergk2mail
2016-03-30 11:03 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EF459E.8000808@gmail.com \
--to=onitake@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sergk.admin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).