From: Arnd Bergmann <arnd@arndb.de>
To: Chao Xie <chao.xie@marvell.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
dmitry.torokhov@gmail.com, haojian.zhuang@gmail.com,
xiechao.mail@gmail.com
Subject: Re: [PATCH V2 4/5] input: pxa27x-keypad: remove the unused members at platform data
Date: Mon, 17 Jun 2013 15:10:27 +0200 [thread overview]
Message-ID: <5701258.F0sLjHKir2@wuerfel> (raw)
In-Reply-To: <1367809448-9437-5-git-send-email-chao.xie@marvell.com>
On Sunday 05 May 2013 23:04:07 Chao Xie wrote:
> Now pxa27x-keypad make use matrix_keymap for matrix keyes, so
> remove the unused members in platform data.
>
> Signed-off-by: Chao Xie <chao.xie@marvell.com>
> ---
> include/linux/platform_data/keypad-pxa27x.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/platform_data/keypad-pxa27x.h b/include/linux/platform_data/keypad-pxa27x.h
> index 0db423b..2462556 100644
> --- a/include/linux/platform_data/keypad-pxa27x.h
> +++ b/include/linux/platform_data/keypad-pxa27x.h
> @@ -39,8 +39,6 @@ struct pxa27x_keypad_platform_data {
> const struct matrix_keymap_data *matrix_keymap_data;
> unsigned int matrix_key_rows;
> unsigned int matrix_key_cols;
> - unsigned int *matrix_key_map;
> - int matrix_key_map_size;
>
> /* direct keys */
> int direct_key_num;
This just broke a number of configurations:
em_x270_defconfig
ezx_defconfig
palmz72_defconfig
pxa3xx_defconfig
You have to make sure that all these board files get converted:
arch/arm/mach-pxa/em-x270.c
arch/arm/mach-pxa/ezx.c
arch/arm/mach-pxa/littleton.c
arch/arm/mach-pxa/mainstone.c
arch/arm/mach-pxa/mioa701.c
arch/arm/mach-pxa/palmld.c
arch/arm/mach-pxa/palmt5.c
arch/arm/mach-pxa/palmtreo.c
arch/arm/mach-pxa/palmtx.c
arch/arm/mach-pxa/palmz72.c
arch/arm/mach-pxa/tavorevb.c
arch/arm/mach-pxa/z2.c
arch/arm/mach-pxa/zylonite.c
or leave the code to interpret that platform data in place.
Arnd
next prev parent reply other threads:[~2013-06-17 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 3:04 [PATCH V2 0/5] input: pxa27x-keypad: enhancement and device tree support Chao Xie
2013-05-06 3:04 ` [PATCH V2 1/5] input: pxa27x-keypad: use matrix_keymap for matrix keyes Chao Xie
2013-05-06 3:04 ` [PATCH V2 2/5] arm: mmp: use matrix_keymap for aspenite Chao Xie
2013-05-06 3:04 ` [PATCH V2 3/5] arm: mmp: use matrix_keymap for teton_bga Chao Xie
2013-05-06 3:04 ` [PATCH V2 4/5] input: pxa27x-keypad: remove the unused members at platform data Chao Xie
2013-06-17 13:10 ` Arnd Bergmann [this message]
2013-06-17 17:07 ` Dmitry Torokhov
2013-06-18 1:10 ` Chao Xie
2013-05-06 3:04 ` [PATCH V2 5/5] input: pxa27x-keypad: add device tree support Chao Xie
2013-05-13 8:02 ` [PATCH V2 0/5] input: pxa27x-keypad: enhancement and " Chao Xie
2013-05-15 6:40 ` Dmitry Torokhov
2013-06-13 2:47 ` Chao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5701258.F0sLjHKir2@wuerfel \
--to=arnd@arndb.de \
--cc=chao.xie@marvell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiechao.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).