From: Manuel Reimer <mail+linux-input@m-reimer.de>
To: "Clément VUCHENER" <clement.vuchener@gmail.com>
Cc: linux-input <linux-input@vger.kernel.org>
Subject: Re: uinput: ioctls for UI_BEGIN_FF_UPLOAD fails (returns -1). How to debug?
Date: Tue, 5 Apr 2016 21:10:15 +0200 [thread overview]
Message-ID: <57040D97.4070904@m-reimer.de> (raw)
In-Reply-To: <CAM4jgCqEZi=Hu2bv28nWgPYbXNNT40QeqdaCLqN-ajY5Z2DHVQ@mail.gmail.com>
On 04/03/2016 12:21 PM, Clément VUCHENER wrote:
> At line 159 you are passing the address of a stack variable that is no
> longer valid when leaving the "if (1)". So the content of rargs may be
> overwritten by future stack variable like msg_out in the next loop.
> Fix your memory management and you may find out you don't actually
> have any problem with uinput.
Exactly! This seems to have resolved my problem. I did several tries and
so far no more crashes.
https://github.com/M-Reimer/pspaddrv/commit/effbaae8
Thank you very much for finding this one! I don't think I would have
ever found that one and maybe had given up at last...
Now I can continue with some code cleanup, adding the rumble code for
PS4 and finally I'll have to find a way to get the common "emulated
events" for memoryless devices. One solution would be to try to get
ff_memless connected with uinput via kernel patch. I'll give that a try
first.
Manuel
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-04-05 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 18:53 uinput: ioctls for UI_BEGIN_FF_UPLOAD fails (returns -1). How to debug? Manuel Reimer
2016-03-27 19:11 ` Clément VUCHENER
2016-03-28 8:53 ` Manuel Reimer
2016-03-29 10:21 ` Clément VUCHENER
2016-03-29 16:48 ` Manuel Reimer
2016-03-31 17:46 ` Manuel Reimer
2016-04-03 10:02 ` Manuel Reimer
2016-04-03 10:21 ` Clément VUCHENER
2016-04-05 19:10 ` Manuel Reimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57040D97.4070904@m-reimer.de \
--to=mail+linux-input@m-reimer.de \
--cc=clement.vuchener@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).