From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Marcin Niestroj <m.niestroj@grinn-global.com>,
Tony Lindgren <tony@atomide.com>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
linux-omap@vger.kernel.org, linux-pm@vger.kernel.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] mfd: tps65217: Add power button as subdevice
Date: Mon, 11 Apr 2016 14:05:01 +0300 [thread overview]
Message-ID: <570B84DD.6040003@ti.com> (raw)
In-Reply-To: <20160411103724.GD8094@x1>
On 04/11/2016 01:37 PM, Lee Jones wrote:
> On Mon, 11 Apr 2016, Grygorii Strashko wrote:
>
>> On 04/11/2016 12:44 PM, Lee Jones wrote:
>>> On Mon, 04 Apr 2016, Marcin Niestroj wrote:
>>>
>>>> Add tps65217 power buttor subdevice with assigned IRQ resources.
>>>>
>>>> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
>>>> ---
>>>> drivers/mfd/tps65217.c | 10 ++++++++++
>>>> 1 file changed, 10 insertions(+)
>>>
>>> Applied, thanks.
>>
>> Seems there is dependency from patch 1 :(
>
> What is the dependency?
TPS65217_IRQ_PB definition added in patch 1.
>
>>>> diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
>>>> index a20980f..fd3b5d8 100644
>>>> --- a/drivers/mfd/tps65217.c
>>>> +++ b/drivers/mfd/tps65217.c
>>>> @@ -38,6 +38,10 @@ static struct resource charger_resources[] = {
>>>> DEFINE_RES_IRQ_NAMED(TPS65217_IRQ_USB, "USB"),
>>>> };
>>>>
>>>> +static struct resource pb_resources[] = {
>>>> + DEFINE_RES_IRQ_NAMED(TPS65217_IRQ_PB, "PB"),
>>>> +};
>>>> +
>>>> struct tps65217_irq {
>>>> int mask;
>>>> int interrupt;
>>>> @@ -122,6 +126,12 @@ static struct mfd_cell tps65217s[] = {
>>>> .resources = charger_resources,
>>>> .of_compatible = "ti,tps65217-charger",
>>>> },
>>>> + {
>>>> + .name = "tps65217-pwrbutton",
>>>> + .num_resources = ARRAY_SIZE(pb_resources),
>>>> + .resources = pb_resources,
>>>> + .of_compatible = "ti,tps65217-pwrbutton",
>>>> + },
>>>> };
>>>>
>>>> static irqreturn_t tps65217_irq_thread(int irq, void *data)
>>>
>>
>>
>
--
regards,
-grygorii
next prev parent reply other threads:[~2016-04-11 11:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 17:10 [PATCH 0/5] mfd: tps65217: Add power-button and IRQ support Marcin Niestroj
[not found] ` <1459789865-3704-1-git-send-email-m.niestroj-z3quKL4iOrmQ6ZAhV5LmOA@public.gmane.org>
2016-04-04 17:11 ` [PATCH 0/5] mfd: tps65217: Add power-button support Marcin Niestroj
2016-04-04 17:11 ` [PATCH 1/5] mfd: tps65217: Add support for IRQs Marcin Niestroj
2016-04-05 10:07 ` Grygorii Strashko
2016-04-05 11:16 ` Marcin Niestroj
2016-04-11 8:48 ` Grygorii Strashko
2016-04-11 9:44 ` Lee Jones
2016-04-25 10:50 ` Marcin Niestroj
2016-04-04 17:11 ` [PATCH 2/5] power_supply: tps65217-charger: Fix NULL deref during property export Marcin Niestroj
2016-04-04 17:11 ` [PATCH 3/5] power_supply: tps65217-charger: Add support for IRQs Marcin Niestroj
2016-04-04 17:11 ` [PATCH 4/5] mfd: tps65217: Add power button as subdevice Marcin Niestroj
2016-04-11 9:44 ` Lee Jones
2016-04-11 10:27 ` Grygorii Strashko
2016-04-11 10:37 ` Lee Jones
2016-04-11 11:05 ` Grygorii Strashko [this message]
2016-04-11 12:35 ` Lee Jones
2016-04-04 17:11 ` [PATCH 5/5] Input: Add tps65217 power button driver Marcin Niestroj
2016-04-07 17:57 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570B84DD.6040003@ti.com \
--to=grygorii.strashko@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.niestroj@grinn-global.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).