linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Grant Grundler <grundler@chromium.org>, Rob Herring <robh@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input <linux-input@vger.kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux DeviceTree <devicetree@vger.kernel.org>,
	Hung-yu Wu <hywu@google.com>
Subject: Re: Input: add Atmel Atmegaxx captouch driver
Date: Fri, 6 May 2016 11:19:45 +0200	[thread overview]
Message-ID: <572C61B1.2040508@atmel.com> (raw)
In-Reply-To: <CANEJEGt1Ri7Q-g25U8_KTAb9Z8MfVWH0N5QLaLcdnDuF_wwrtw@mail.gmail.com>

Le 05/05/2016 18:04, Grant Grundler a écrit :
> On Wed, May 4, 2016 at 6:51 AM, Rob Herring <robh@kernel.org> wrote:
> ...
>>> +Required properties:
>>> +
>>> +     compatible:     Must be "atmel,atmegaxx_captouch".
>>
>> No wildcards in the compatible strings. Use the specific devices.
>>
>> Also, use hyphen rather than underscore. However, if the device is only
>> a touch controller, then '_captouch' is not needed. The part number is
>> sufficient to identify the device.
> 
> The primary part used on the board is AtMega88PA. Details of that SoC
> are public:
>     http://www.atmel.com/devices/ATMEGA88PA.aspx
> 
> I don't see why the exact chip is relevant to the driver. The driver
> is just talking to an I2C device that reports button events.  The
> protocol across the I2C determines what this driver has to do and that
> protocol is implemented by the on-board firmware (supplied by Atmel).
> Any AVR CPU could implement this same protocol.
> 
> Can we call this "atmel,qtouch-buttons-v2" or something like that?

Is it different from the Atmel QT1070 or QT2160 which have drivers
already available in Linux:
drivers/input/keyboard/qt1070.c

Bye,

> I personally don't have anything invested in any particular name. Feel
> free to suggest a different one. I'm perfectly happy with any color
> paint on the shed.
> 
> ...
>>> +Example:
>>> +
>>> +     atmegaxx_captouch@51 {
>>
>> atmegaxx@51 (with actual part number)
> 
> Is "qtouch-buttons@51" ok?
> 
>>
>>> +             compatible = "atmel,atmegaxx_captouch";
>>> +             reg = <0x51>;
>>> +             interrupt-parent = <&tlmm>;
>>> +             interrupts = <67 IRQ_TYPE_EDGE_FALLING>;
>>> +             linux,keycodes = <BTN_0>, <BTN_1>,
>>> +                     <BTN_2>, <BTN_3>,
>>> +                     <BTN_4>, <BTN_5>,
>>> +                     <BTN_6>, <BTN_7>;
>>> +             autorepeat;
>>> +     };
> 
> cheers,
> grant
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-05-06  9:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03 17:13 Input: add Atmel Atmegaxx captouch driver Grant Grundler
2016-05-04 13:51 ` Rob Herring
2016-05-04 16:43   ` Grant Grundler
2016-05-05 16:04   ` Grant Grundler
2016-05-06  9:19     ` Nicolas Ferre [this message]
     [not found]       ` <572C61B1.2040508-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2016-05-06 18:29         ` Grant Grundler
     [not found]       ` <CAHHoo-j7145vPFNmJH=CvPu-BRCgRe0WNKH8QDkSc+c3koxHAQ@mail.gmail.com>
     [not found]         ` <CAHHoo-j7145vPFNmJH=CvPu-BRCgRe0WNKH8QDkSc+c3koxHAQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-09 16:29           ` Dmitry Torokhov
2016-05-09 16:44             ` Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572C61B1.2040508@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=grant.likely@linaro.org \
    --cc=grundler@chromium.org \
    --cc=hywu@google.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).