From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH] HID: usbkbd: return proper error code Date: Wed, 31 Aug 2016 23:08:28 +0530 Message-ID: <57C71614.6050807@gmail.com> References: <1472660901-1912-1-git-send-email-sudipm.mukherjee@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:36692 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934811AbcHaRik (ORCPT ); Wed, 31 Aug 2016 13:38:40 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Fabio Estevam Cc: Jiri Kosina , Benjamin Tissoires , linux-kernel , USB list , linux-input@vger.kernel.org On Wednesday 31 August 2016 10:03 PM, Fabio Estevam wrote: > On Wed, Aug 31, 2016 at 1:28 PM, Sudip Mukherjee > wrote: >> Use proper error code instead of using -1 on failure to allocate >> memory. We may use the error code later in the caller. >> >> Signed-off-by: Sudip Mukherjee >> --- >> drivers/hid/usbhid/usbkbd.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c >> index 9a332e6..ee53359 100644 >> --- a/drivers/hid/usbhid/usbkbd.c >> +++ b/drivers/hid/usbhid/usbkbd.c >> @@ -249,15 +249,15 @@ static void usb_kbd_close(struct input_dev *dev) >> static int usb_kbd_alloc_mem(struct usb_device *dev, struct usb_kbd *kbd) >> { >> if (!(kbd->irq = usb_alloc_urb(0, GFP_KERNEL))) >> - return -1; >> + return -ENOMEM; > > While you are it, the code would look better like this: > > kbd->irq = usb_alloc_urb(0, GFP_KERNEL) > if (!kbd->irq) > return -ENOMEM; > Yes, it will. But that will become two changes in one patch. I will send a series with this sent patch and another patch to reorder the assignment. regards sudip