From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 202C51DB125 for ; Wed, 6 Aug 2025 15:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754493202; cv=none; b=j8cfFbLXbkO+xFe0st2EPFfiSlAD8iNGfTboiHknlgVqVrnfHEPBuq6qGksIoBd86pC+X9nRV/28HeO7c67KrxkNORWFpNu35PiDBJtAiaOBpg6S3ZVe3uzZ/2cb6bpkgjCCEH8niwXiCYuEEVQe/A5cCjBBRUfWpfAbc+jr6a4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754493202; c=relaxed/simple; bh=E1ywD+6b5TLidW881C8mih+zT9s566iOTR/teEUThjs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Udp77Ywxd5OxxyoqkpTF7pbYSydQ5GcrHY7kwWaoQ98zKPTeIXaEjhkZI0H8bKP2p3vOjhw7IRjU7PsxWsBgTjdUtkkUaivOoP1GZyJFhRt7M7dqTIytJIoZWEh35SlzkKP7CSW89b4AUIT9sxRpfvb5+oBLdJVO4QvuawWRLWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=khTcZuR5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="khTcZuR5" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 576C6HnF025397 for ; Wed, 6 Aug 2025 15:13:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FoD5ue7FLv/tVVaOYwgBAkYsHyRWsTQqwoytYtbdy8s=; b=khTcZuR5SEhABMhO WwwhLWA5NvWeZ3UTRbz//6qHPRP6zoOaKH+jm41Ar0R3QiURPxJlIeRaiCI1mjvJ hf2GyoYqtjuusjbVywIroHfjbUZoftoUdB+Dn8a5hYBAhE11k/OuvYZrGVRq7q8i Ts6pnSkBprKFdNFQyTDqDEvkZKzRLA2icIDCFnLQO0w60667mcNcNV6q+UZh4NzO eYvDXM4aJVtOpRmQX6zGoby+oVH6PiLU2dsSKrQUNCkSHkqU/NOjxpGD0IDhYwdO nQeI6eDpKV3q5tURWaYc190g3xOcnhBcfkE3sNPHAD3z6siBecp0rT0Js/sLJDVJ ebpO+g== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48bpvyu8r8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 06 Aug 2025 15:13:20 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-7096ce64bb8so110576d6.2 for ; Wed, 06 Aug 2025 08:13:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754493199; x=1755097999; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FoD5ue7FLv/tVVaOYwgBAkYsHyRWsTQqwoytYtbdy8s=; b=G1KWjxQxtqZPCyxLYKQlzKpmPa2Hp1tSQ2MQ9018OS/hww49cIlcUsagOQmVt9EikU 39fQOjoRpo5/3nG0MrE19m2pmrXK6cEGrtcNL6mKH6YMu+uymAVgqKZ2vjQ5aKDRbDCu saa+DJj9JbAEt3vu4kt6e03b2nKJkeTIHMGr3ZTcu4AcwCSuRVxXwBXz6sfdp8JNi+FM j6rVxDgH2YsdIi9ddUZI/dLCwHzovuFjCBbYR5T0i0bmo44duZPoVPXQHFl0j7ycCZG0 hZsGlIk/G/DFKgoMyg0k5D/y5YVeJJ1bJw4QUE/IHN/P+EO64nNMFF3O+xVdxDkLVhxq 2L/w== X-Gm-Message-State: AOJu0Yy3TQujF8/5btsIr8xmLcu1jzBhuZpuBTBuTxmNOAgEu+i/4yjR Yy8Stf6ZJXdbMX5WN7qWHV5ap6jSQVusDhDNL7SvopiKkU5qsnWyHFPa8L0zPHQLYbKnI8mlfF0 MVYscXdRGI/3VAvQPtf3PuBJdfgkRnTN6mU64ugP2zBI4o2fmavZzxEl8A+qRgyljGA== X-Gm-Gg: ASbGncs+Ln/HNfz2534tK1/aQvlqXr9mgUqABN+t0W6s9D7OKvwVZGkfmojJGwlf/aB dj7fGtwFoepnIzAEFv4GwRSs6eng9FCbVUql7arm5Rr6SDeWU0jxJMUmGtsXRrrmZWeeJJGbf77 s+23e4KbppPFDfJnZ/6BsA0zVd7NaZACW6OWc/VyfSe2rPAXcph+vsOJXk7w83AVrTYBfXSuzra eJyOmR0zx4XM1XRv7nHvPiiy1b0RgATTjHr5bO/YkLIlzwk0wOCTxccPAWGt+G/ElVDKpD9k8iP 3Z4YQ4AIuygyUUsBNok9d6kXjR6BsExrPfL9q5PFqicAe5QoL2gmJ0h+fvspkDdJFisZHoi4Z/T aRSSg47HRam5K5J7i5A== X-Received: by 2002:a05:622a:486:b0:4a9:9695:64c0 with SMTP id d75a77b69052e-4b091575d69mr22519671cf.8.1754493198889; Wed, 06 Aug 2025 08:13:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEVjPaBvVyXemUS3cDbhkwc4YdKlt9IkD9oqd8GDTb3Ol2Pm9hJNwgpylnDtIcL+fPMzpoJVQ== X-Received: by 2002:a05:622a:486:b0:4a9:9695:64c0 with SMTP id d75a77b69052e-4b091575d69mr22519121cf.8.1754493198074; Wed, 06 Aug 2025 08:13:18 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a219ecfsm1118111766b.94.2025.08.06.08.13.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Aug 2025 08:13:17 -0700 (PDT) Message-ID: <581aaa8f-9e08-475e-ad23-3369fa05e53e@oss.qualcomm.com> Date: Wed, 6 Aug 2025 17:13:15 +0200 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: Add vibrator support To: Griffin Kroah-Hartman , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Luca Weiss Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20250806-aw86927-v1-0-23d8a6d0f2b2@fairphone.com> <20250806-aw86927-v1-3-23d8a6d0f2b2@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250806-aw86927-v1-3-23d8a6d0f2b2@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: sM0PpHm-3Aqh3CnDfynSTQXb3ltEqC-L X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA2MDAwOSBTYWx0ZWRfXyK7ttKPwpmeb RnmQHSY91KyJ5/Q7Pf6ezthNaWcQvWMCEzTg5yDdK50Cyxkz5htn44OuC828JgYpS2bxuzCVZqe 9dImlg8Qu0jADp/BWY9KmemqclpMvAsSC7iUFinr3Pr3WgHb/ymU6ZsNLlDcFP76seoC4S7urwq Yp6OPJYJZvDk/57tVeAKGI++lhZnQx9AWFcRafR7+LUmRIXyrmVXbQs+KRClH0Wfg6Qr4wvDXRK UX1bhcygIfucCNYXr7POb2D7Q6AyJPzCOL4CAdEuiBuxxKke3zJQrl1ITzfUSYXjr7EsTo/Ry2Y pxeRqlMiMuqtXqFu0szGFJ6uARXBF0BiJO93hCHhf1NIqeXiGdgngVt9eh084i+sOm1Dmn2vaRG 1IPjbGH1 X-Proofpoint-ORIG-GUID: sM0PpHm-3Aqh3CnDfynSTQXb3ltEqC-L X-Authority-Analysis: v=2.4 cv=NsLRc9dJ c=1 sm=1 tr=0 ts=68937110 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=6H0WHjuAAAAA:8 a=EUspDBNiAAAA:8 a=ZdkvxXOI2w3T0V8kwTkA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-06_04,2025-08-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 priorityscore=1501 impostorscore=0 bulkscore=0 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508060009 On 8/6/25 5:10 PM, Griffin Kroah-Hartman wrote: > Add the required node for haptic playback (Awinic AW86927). > > Signed-off-by: Griffin Kroah-Hartman > --- > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > index 4c6cb4a644e2..9576efdf1e8d 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > @@ -866,7 +866,16 @@ ocp96011_sbu_mux: endpoint { > }; > }; > > - /* AW86927FCR haptics @ 5a */ > + vibrator@5a { > + compatible = "awinic,aw86927"; I noticed the suffix is absent in the compatible - does it matter for discerning the particular chip and other variants? Anyway, so long as you and the bindings folks agree on it: Reviewed-by: Konrad Dybcio Konrad