From: Dan Murphy <dmurphy@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: drv260x - fix initializing overdrive voltage
Date: Mon, 12 Dec 2016 07:00:29 -0600 [thread overview]
Message-ID: <584E9F6D.1080209@ti.com> (raw)
In-Reply-To: <20161211065956.GA17809@dtor-ws>
Dmitry
On 12/11/2016 12:59 AM, Dmitry Torokhov wrote:
> We were accidentally initializing haptics->rated_voltage twice, and did not
> initialize overdrive voltage.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/misc/drv260x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
> index 2adfd86c..9789d4f 100644
> --- a/drivers/input/misc/drv260x.c
> +++ b/drivers/input/misc/drv260x.c
> @@ -521,7 +521,7 @@ static int drv260x_probe(struct i2c_client *client,
> if (!haptics)
> return -ENOMEM;
>
> - haptics->rated_voltage = DRV260X_DEF_OD_CLAMP_VOLT;
> + haptics->overdrive_voltage = DRV260X_DEF_OD_CLAMP_VOLT;
> haptics->rated_voltage = DRV260X_DEF_RATED_VOLT;
>
> if (pdata) {
Thanks for the fix
Acked-by: Dan Murphy <dmurphy@ti.com>
--
------------------
Dan Murphy
prev parent reply other threads:[~2016-12-12 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-11 6:59 [PATCH] Input: drv260x - fix initializing overdrive voltage Dmitry Torokhov
2016-12-12 13:00 ` Dan Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=584E9F6D.1080209@ti.com \
--to=dmurphy@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).