From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE Date: Wed, 29 Oct 2014 12:31:31 -0700 Message-ID: <58957675.Bh6LToE4gg@dtor-glaptop> References: <1413636974-3244-1-git-send-email-linus.walleij@linaro.org> <20141020064605.GB25349@x1> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mail-pa0-f41.google.com ([209.85.220.41]:42828 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752359AbaJ2Tbg (ORCPT ); Wed, 29 Oct 2014 15:31:36 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Linus Walleij Cc: Lee Jones , Samuel Ortiz , "linux-kernel@vger.kernel.org" , Linux Input On Wednesday, October 29, 2014 10:55:14 AM Linus Walleij wrote: > On Mon, Oct 20, 2014 at 8:46 AM, Lee Jones wrote: > > On Sat, 18 Oct 2014, Linus Walleij wrote: > >> This adds the register offsets for pull up/down for the STMPE > >> 1601, 1801 and 24xx expanders. This is used to bias GPIO lines > >> and keypad lines. > >> > >> Signed-off-by: Linus Walleij > >> --- > >> Hi Sam, Lee: I think you should just ACK this so Dmitry can take the > >> patch series through the input tree, where the registers need to be > >> used to enable the keypad on the STMPE2401. > >> --- > >> > >> drivers/mfd/stmpe.c | 4 ++++ > >> drivers/mfd/stmpe.h | 3 +++ > >> include/linux/mfd/stmpe.h | 2 ++ > >> 3 files changed, 9 insertions(+) > > > > Does this need to go in with the other patches in the set? > > > > I'm _guessing_ that, as you've sent them separately, they can be > > applied separately? > > No sorry if it was unclear, the series need to go in toghether. > So this patch adds some infrastructure to the MFD device which > is then utilized by the input driver in a later patch. > > > This needs to go in via MFD, but for my own reference: > > > > Acked-by: Lee Jones > > Dmitry can you merge this & the rest with Lee's ACK? I'd be delighted, but it _sounded_ like Lee wanted it to go though MFD? Thanks. -- Dmitry