From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Subject: Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL Date: Tue, 28 Feb 2017 07:13:43 +0100 Message-ID: <58B51517.4050003@denx.de> References: <1487579863-7256-1-git-send-email-hs@denx.de> <06af466d-ac78-ea38-77d2-3bf32a6e157c@lechnology.com> <58B5084A.9000709@denx.de> Reply-To: hs@denx.de Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: David Lechner Cc: linux-input@vger.kernel.org, Guan Ben , Mark Jonas , devicetree@vger.kernel.org, Thierry Reding , linux-kernel@vger.kernel.org, Boris Brezillon , Rob Herring , Dmitry Torokhov , Manfred Schlaegl , Mark Rutland List-Id: linux-input@vger.kernel.org Hello David, Am 28.02.2017 um 06:30 schrieb David Lechner: > On 02/27/2017 11:19 PM, Heiko Schocher wrote: >> Hello David, >> >> Am 27.02.2017 um 19:11 schrieb David Lechner: >>> On 02/20/2017 02:37 AM, Heiko Schocher wrote: >>>> From: Guan Ben >>>> >>>> extend the pwm-beeper driver to support customized frequency >>>> for SND_BELL from device tree. >>>> >>>> Signed-off-by: Guan Ben >>>> Signed-off-by: Mark Jonas >>>> [hs@denx.de: adapted to 4.10-rc7] >>>> Signed-off-by: Heiko Schocher >>>> --- >>>> >>>> Changes in v2: >>>> - add comment from Rob Herring: >>>> rename property name "bell-frequency" to "beeper-hz" >>> >>> Is there a separate patch for the devicetree bindings documentation? >> >> No, it is in this patch ... In the meantime I got an >> Acked-by from Rob Herring ... >> > > What I should have said is that, in general, I think it is preferred to have the device tree > bindings as a separate patch from the code changes. I can split this into 2 patches ... bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany