* [PATCH] HID: wacom: Mark expected switch fall-through
@ 2019-02-11 22:04 Gustavo A. R. Silva
2019-02-13 23:07 ` Jiri Kosina
0 siblings, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-11 22:04 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires
Cc: linux-input, linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/hid/wacom_wac.c: In function ‘wacom_setup_pen_input_capabilities’:
drivers/hid/wacom_wac.c:3506:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
__clear_bit(ABS_MISC, input_dev->absbit);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/wacom_wac.c:3508:2: note: here
case WACOM_MO:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/hid/wacom_wac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
index 72477e872324..5ecda99bf431 100644
--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -3504,6 +3504,7 @@ int wacom_setup_pen_input_capabilities(struct input_dev *input_dev,
switch (features->type) {
case GRAPHIRE_BT:
__clear_bit(ABS_MISC, input_dev->absbit);
+ /* fall through */
case WACOM_MO:
case WACOM_G4:
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: wacom: Mark expected switch fall-through
2019-02-11 22:04 [PATCH] HID: wacom: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-02-13 23:07 ` Jiri Kosina
2019-02-13 23:19 ` Gustavo A. R. Silva
[not found] ` <CAF8JNh+EzcCoOvyTm59p99Cg_3S4adGcnpKs4QkpZStsU=XURA@mail.gmail.com>
0 siblings, 2 replies; 5+ messages in thread
From: Jiri Kosina @ 2019-02-13 23:07 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Benjamin Tissoires, linux-input, linux-kernel, Kees Cook,
Jason Gerecke, Ping Cheng
On Mon, 11 Feb 2019, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/hid/wacom_wac.c: In function ‘wacom_setup_pen_input_capabilities’:
> drivers/hid/wacom_wac.c:3506:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> __clear_bit(ABS_MISC, input_dev->absbit);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/hid/wacom_wac.c:3508:2: note: here
> case WACOM_MO:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Let's CC Jason and Ping to make sure it's really intended :)
> ---
> drivers/hid/wacom_wac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
> index 72477e872324..5ecda99bf431 100644
> --- a/drivers/hid/wacom_wac.c
> +++ b/drivers/hid/wacom_wac.c
> @@ -3504,6 +3504,7 @@ int wacom_setup_pen_input_capabilities(struct input_dev *input_dev,
> switch (features->type) {
> case GRAPHIRE_BT:
> __clear_bit(ABS_MISC, input_dev->absbit);
> + /* fall through */
>
> case WACOM_MO:
> case WACOM_G4:
> --
> 2.20.1
>
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: wacom: Mark expected switch fall-through
2019-02-13 23:07 ` Jiri Kosina
@ 2019-02-13 23:19 ` Gustavo A. R. Silva
[not found] ` <CAF8JNh+EzcCoOvyTm59p99Cg_3S4adGcnpKs4QkpZStsU=XURA@mail.gmail.com>
1 sibling, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-13 23:19 UTC (permalink / raw)
To: Jiri Kosina
Cc: Benjamin Tissoires, linux-input, linux-kernel, Kees Cook,
Jason Gerecke, Ping Cheng
On 2/13/19 5:07 PM, Jiri Kosina wrote:
> On Mon, 11 Feb 2019, Gustavo A. R. Silva wrote:
>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/hid/wacom_wac.c: In function ‘wacom_setup_pen_input_capabilities’:
>> drivers/hid/wacom_wac.c:3506:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> __clear_bit(ABS_MISC, input_dev->absbit);
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/hid/wacom_wac.c:3508:2: note: here
>> case WACOM_MO:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Let's CC Jason and Ping to make sure it's really intended :)
>
Sounds great.
Thanks, Jiri.
--
Gustavo
>> ---
>> drivers/hid/wacom_wac.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
>> index 72477e872324..5ecda99bf431 100644
>> --- a/drivers/hid/wacom_wac.c
>> +++ b/drivers/hid/wacom_wac.c
>> @@ -3504,6 +3504,7 @@ int wacom_setup_pen_input_capabilities(struct input_dev *input_dev,
>> switch (features->type) {
>> case GRAPHIRE_BT:
>> __clear_bit(ABS_MISC, input_dev->absbit);
>> + /* fall through */
>>
>> case WACOM_MO:
>> case WACOM_G4:
>> --
>> 2.20.1
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: wacom: Mark expected switch fall-through
[not found] ` <CAF8JNh+EzcCoOvyTm59p99Cg_3S4adGcnpKs4QkpZStsU=XURA@mail.gmail.com>
@ 2019-02-14 23:06 ` Gustavo A. R. Silva
2019-02-15 7:46 ` Jiri Kosina
1 sibling, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-14 23:06 UTC (permalink / raw)
To: Ping Cheng, Jiri Kosina
Cc: Benjamin Tissoires, linux-input, linux-kernel, Kees Cook,
Jason Gerecke, Ping Cheng
On 2/14/19 4:33 PM, Ping Cheng wrote:
> On Thu, Feb 14, 2019 at 6:01 AM Jiri Kosina <jikos@kernel.org> wrote:
>
>> On Mon, 11 Feb 2019, Gustavo A. R. Silva wrote:
>>
>>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>>> cases where we are expecting to fall through.
>>>
>>> This patch fixes the following warning:
>>>
>>> drivers/hid/wacom_wac.c: In function
>> ‘wacom_setup_pen_input_capabilities’:
>>> drivers/hid/wacom_wac.c:3506:3: warning: this statement may fall through
>> [-Wimplicit-fallthrough=]
>>> __clear_bit(ABS_MISC, input_dev->absbit);
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/hid/wacom_wac.c:3508:2: note: here
>>> case WACOM_MO:
>>> ^~~~
>>>
>>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>>
>>> This patch is part of the ongoing efforts to enable
>>> -Wimplicit-fallthrough.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>
>> Let's CC Jason and Ping to make sure it's really intended :)
>>
>
> Yes, it was intended. You can have my Acked-by: Ping Cheng <
> ping.cheng@wacom.com>
>
Great.
Thanks, Ping.
--
Gustavo
> Cheers,
> Ping
>
>
>>
>>> ---
>>> drivers/hid/wacom_wac.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
>>> index 72477e872324..5ecda99bf431 100644
>>> --- a/drivers/hid/wacom_wac.c
>>> +++ b/drivers/hid/wacom_wac.c
>>> @@ -3504,6 +3504,7 @@ int wacom_setup_pen_input_capabilities(struct
>> input_dev *input_dev,
>>> switch (features->type) {
>>> case GRAPHIRE_BT:
>>> __clear_bit(ABS_MISC, input_dev->absbit);
>>> + /* fall through */
>>>
>>> case WACOM_MO:
>>> case WACOM_G4:
>>> --
>>> 2.20.1
>>>
>>
>> --
>> Jiri Kosina
>> SUSE Labs
>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: wacom: Mark expected switch fall-through
[not found] ` <CAF8JNh+EzcCoOvyTm59p99Cg_3S4adGcnpKs4QkpZStsU=XURA@mail.gmail.com>
2019-02-14 23:06 ` Gustavo A. R. Silva
@ 2019-02-15 7:46 ` Jiri Kosina
1 sibling, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2019-02-15 7:46 UTC (permalink / raw)
To: Ping Cheng
Cc: Gustavo A. R. Silva, Benjamin Tissoires, linux-input,
linux-kernel, Kees Cook, Jason Gerecke, Ping Cheng
On Thu, 14 Feb 2019, Ping Cheng wrote:
> Yes, it was intended. You can have my Acked-by: Ping Cheng <
> ping.cheng@wacom.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-15 7:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-11 22:04 [PATCH] HID: wacom: Mark expected switch fall-through Gustavo A. R. Silva
2019-02-13 23:07 ` Jiri Kosina
2019-02-13 23:19 ` Gustavo A. R. Silva
[not found] ` <CAF8JNh+EzcCoOvyTm59p99Cg_3S4adGcnpKs4QkpZStsU=XURA@mail.gmail.com>
2019-02-14 23:06 ` Gustavo A. R. Silva
2019-02-15 7:46 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).