* [PATCH] Input: i8042 - add noloop quirk for Acer P459-G2-M
@ 2023-11-28 21:48 Esther Shimanovich
2023-11-29 8:46 ` Hans de Goede
2023-11-29 19:31 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Esther Shimanovich @ 2023-11-28 21:48 UTC (permalink / raw)
To: LKML
Cc: linux-input, Esther Shimanovich, Dmitry Torokhov, Hans de Goede,
Jonathan Denose, Mattijs Korpershoek, Werner Sembach
On the Acer P450-G2-M, after the user opens the laptop lid and the device
resumes from S3 deep sleep, the screen remains dark for a few seconds.
If the user presses a keyboard key while the screen is still dark, the
mouse and keyboard stop functioning.
To fix this bug, enable the noloop quirk.
Signed-off-by: Esther Shimanovich <eshimanovich@chromium.org>
---
drivers/input/serio/i8042-acpipnpio.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h
index 028e45bd050bf..b81539bacb931 100644
--- a/drivers/input/serio/i8042-acpipnpio.h
+++ b/drivers/input/serio/i8042-acpipnpio.h
@@ -941,6 +941,14 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
},
.driver_data = (void *)(SERIO_QUIRK_NOPNP)
},
+ {
+ /* Acer TravelMate P459-G2-M */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate P459-G2-M"),
+ },
+ .driver_data = (void *)(SERIO_QUIRK_NOLOOP)
+ },
{
/* ULI EV4873 - AUX LOOP does not work properly */
.matches = {
--
2.43.0.rc1.413.gea7ed67945-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Input: i8042 - add noloop quirk for Acer P459-G2-M
2023-11-28 21:48 [PATCH] Input: i8042 - add noloop quirk for Acer P459-G2-M Esther Shimanovich
@ 2023-11-29 8:46 ` Hans de Goede
2023-11-29 19:31 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2023-11-29 8:46 UTC (permalink / raw)
To: Esther Shimanovich, LKML
Cc: linux-input, Dmitry Torokhov, Jonathan Denose,
Mattijs Korpershoek, Werner Sembach
Hi,
On 11/28/23 22:48, Esther Shimanovich wrote:
> On the Acer P450-G2-M, after the user opens the laptop lid and the device
> resumes from S3 deep sleep, the screen remains dark for a few seconds.
> If the user presses a keyboard key while the screen is still dark, the
> mouse and keyboard stop functioning.
>
> To fix this bug, enable the noloop quirk.
>
> Signed-off-by: Esther Shimanovich <eshimanovich@chromium.org>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
>
> drivers/input/serio/i8042-acpipnpio.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h
> index 028e45bd050bf..b81539bacb931 100644
> --- a/drivers/input/serio/i8042-acpipnpio.h
> +++ b/drivers/input/serio/i8042-acpipnpio.h
> @@ -941,6 +941,14 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
> },
> .driver_data = (void *)(SERIO_QUIRK_NOPNP)
> },
> + {
> + /* Acer TravelMate P459-G2-M */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate P459-G2-M"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOLOOP)
> + },
> {
> /* ULI EV4873 - AUX LOOP does not work properly */
> .matches = {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Input: i8042 - add noloop quirk for Acer P459-G2-M
2023-11-28 21:48 [PATCH] Input: i8042 - add noloop quirk for Acer P459-G2-M Esther Shimanovich
2023-11-29 8:46 ` Hans de Goede
@ 2023-11-29 19:31 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2023-11-29 19:31 UTC (permalink / raw)
To: Esther Shimanovich
Cc: LKML, linux-input, Hans de Goede, Jonathan Denose,
Mattijs Korpershoek, Werner Sembach
On Tue, Nov 28, 2023 at 09:48:54PM +0000, Esther Shimanovich wrote:
> On the Acer P450-G2-M, after the user opens the laptop lid and the device
> resumes from S3 deep sleep, the screen remains dark for a few seconds.
> If the user presses a keyboard key while the screen is still dark, the
> mouse and keyboard stop functioning.
>
> To fix this bug, enable the noloop quirk.
Are you sure that you want to disable loop and not mux mode? The only
time we issue the "AUX LOOP" command on resume is when we try to restore
MUX configuration...
>
> Signed-off-by: Esther Shimanovich <eshimanovich@chromium.org>
> ---
>
> drivers/input/serio/i8042-acpipnpio.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h
> index 028e45bd050bf..b81539bacb931 100644
> --- a/drivers/input/serio/i8042-acpipnpio.h
> +++ b/drivers/input/serio/i8042-acpipnpio.h
> @@ -941,6 +941,14 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
> },
> .driver_data = (void *)(SERIO_QUIRK_NOPNP)
> },
> + {
> + /* Acer TravelMate P459-G2-M */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate P459-G2-M"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOLOOP)
> + },
> {
> /* ULI EV4873 - AUX LOOP does not work properly */
> .matches = {
> --
> 2.43.0.rc1.413.gea7ed67945-goog
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-29 19:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 21:48 [PATCH] Input: i8042 - add noloop quirk for Acer P459-G2-M Esther Shimanovich
2023-11-29 8:46 ` Hans de Goede
2023-11-29 19:31 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).