From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v2] input: touchscreen: Add support for Elan eKTF2127 touchscreen controller Date: Sat, 17 Sep 2016 14:04:28 +0200 Message-ID: <5d188602-e98c-e600-115f-51cf84cc5926@redhat.com> References: <20160828160005.20415-1-hdegoede@redhat.com> <20160902140935.GA19453@rob-hp-laptop> <20160916185654.GA14732@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38242 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753234AbcIQMEe (ORCPT ); Sat, 17 Sep 2016 08:04:34 -0400 In-Reply-To: <20160916185654.GA14732@dtor-ws> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov , Rob Herring Cc: linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree , Siebren Vroegindeweij , Michel Verlaan , Siebren Vroegindeweij Hi, On 16-09-16 20:56, Dmitry Torokhov wrote: > On Fri, Sep 02, 2016 at 09:09:35AM -0500, Rob Herring wrote: >> On Sun, Aug 28, 2016 at 06:00:05PM +0200, Hans de Goede wrote: >>> From: Siebren Vroegindeweij >>> >>> This adds a driver for the Elan eKTF2127 touchscreen controller, >>> which speaks an i2c protocol which is distinctly different from >>> the already supported eKTH controllers. >>> >>> Signed-off-by: Michel Verlaan >>> Signed-off-by: Siebren Vroegindeweij >>> Signed-off-by: Hans de Goede >>> --- >>> Changes in v2: >>> -Improve devicetree bindings document >>> -Use touchscreen_parse_properties and touchscreen_report_pos instead of DIY >>> -Remove a bunch of unused defines (copy and paste leftover from chipone driver) >>> -Some other minor cleanups and review comments addressed >>> -Add defines for some command / address hex-values >>> -Check packet header in interrupt handler >>> --- >>> .../bindings/input/touchscreen/ektf2127.txt | 27 ++ >> >> Acked-by: Rob Herring > > I'd like to merge the version below (factored out querying dimensions > and parsing/reporting touch), can you please give it a spin? Just tested it, works as advertised. Nice cleanup, esp. the refactoring of the dimension querying, I should have tought of that myself. Regards, Hans