From: "Trilok Soni" <soni.trilok@gmail.com>
To: Lauri Leukkunen <lauri.leukkunen@nokia.com>
Cc: ext Sam Ravnborg <sam@ravnborg.org>,
David Brownell <david-b@pacbell.net>,
dmitry.torokhov@gmail.com,
"linux-omap@vger.kernel.org Mailing List"
<linux-omap@vger.kernel.org>,
linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Add TI TSC2005 Touchscreen driver
Date: Wed, 10 Dec 2008 12:44:21 +0530 [thread overview]
Message-ID: <5d5443650812092314s4b51abb2me5e0f16a36d2c18c@mail.gmail.com> (raw)
In-Reply-To: <20081209131705.GC6667@pure.research.nokia.com>
Hi Lauri,
On Tue, Dec 9, 2008 at 6:47 PM, Lauri Leukkunen
<lauri.leukkunen@nokia.com> wrote:
> On 08/12/08 19:26 +0100, ext Sam Ravnborg wrote:
>> > Add Texas Instruments TSC2005 chip touchscreen driver.
>> >
>> > Signed-off-by: Trilok Soni <soni.trilok@gmail.com>
>>
>> Hi Trilok.
>> A few nitpicks below.
>>
>> In general a very clean written driver with adequate comments - nice work!
>
> Umm, isn't this code mostly written by Nokia? At least I remember modifying
> some of it, and this version looks like Konsta Karsisto might be the last
> person touching it. Originally I think it's written by Imre Deak, probably
> based on the tsc2301 code.
Yes, you are the author. Please check first few lines of this patch,
--from field has your name :)
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
next prev parent reply other threads:[~2008-12-10 7:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 17:49 [PATCH] Add TI TSC2005 Touchscreen driver Trilok Soni
2008-12-08 18:26 ` Sam Ravnborg
[not found] ` <20081208182648.GA9740-QabhHTsIXMSnlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org>
2008-12-09 13:17 ` Lauri Leukkunen
2008-12-10 7:14 ` Trilok Soni [this message]
2008-12-18 7:55 ` Trilok Soni
2008-12-08 18:28 ` Felipe Balbi
2009-01-03 4:38 ` Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5443650812092314s4b51abb2me5e0f16a36d2c18c@mail.gmail.com \
--to=soni.trilok@gmail.com \
--cc=david-b@pacbell.net \
--cc=dmitry.torokhov@gmail.com \
--cc=lauri.leukkunen@nokia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).