From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Trilok Soni" Subject: Re: [PATCH] Add TI TSC2005 Touchscreen driver Date: Wed, 10 Dec 2008 12:44:21 +0530 Message-ID: <5d5443650812092314s4b51abb2me5e0f16a36d2c18c@mail.gmail.com> References: <5d5443650812080949h5aff6010mb7341f581841f126@mail.gmail.com> <20081208182648.GA9740@uranus.ravnborg.org> <20081209131705.GC6667@pure.research.nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wf-out-1314.google.com ([209.85.200.174]:49399 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754091AbYLJHOW (ORCPT ); Wed, 10 Dec 2008 02:14:22 -0500 Received: by wf-out-1314.google.com with SMTP id 27so37952wfd.4 for ; Tue, 09 Dec 2008 23:14:21 -0800 (PST) In-Reply-To: <20081209131705.GC6667@pure.research.nokia.com> Content-Disposition: inline Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Lauri Leukkunen Cc: ext Sam Ravnborg , David Brownell , dmitry.torokhov@gmail.com, "linux-omap@vger.kernel.org Mailing List" , linux-kernel@vger.kernel.org, spi-devel-general@lists.sourceforge.net, linux-input@vger.kernel.org Hi Lauri, On Tue, Dec 9, 2008 at 6:47 PM, Lauri Leukkunen wrote: > On 08/12/08 19:26 +0100, ext Sam Ravnborg wrote: >> > Add Texas Instruments TSC2005 chip touchscreen driver. >> > >> > Signed-off-by: Trilok Soni >> >> Hi Trilok. >> A few nitpicks below. >> >> In general a very clean written driver with adequate comments - nice work! > > Umm, isn't this code mostly written by Nokia? At least I remember modifying > some of it, and this version looks like Konsta Karsisto might be the last > person touching it. Originally I think it's written by Imre Deak, probably > based on the tsc2301 code. Yes, you are the author. Please check first few lines of this patch, --from field has your name :) -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni