From: Trilok Soni <soni.trilok@gmail.com>
To: me@felipebalbi.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
dmitry.torokhov@gmail.com, felipe.balbi@nokia.com
Subject: Re: [PATCH] input: keyboard: introduce lm8323 driver
Date: Sat, 21 Feb 2009 13:20:00 +0530 [thread overview]
Message-ID: <5d5443650902202350p206e58ebvcd9becfd04a4133@mail.gmail.com> (raw)
In-Reply-To: <20090220225247.GY32564@gandalf>
Hi Felipe,
On Sat, Feb 21, 2009 at 4:22 AM, Felipe Balbi <me@felipebalbi.com> wrote:
> On Sat, Feb 21, 2009 at 12:29:12AM +0200, Felipe Balbi wrote:
>> On Fri, Feb 20, 2009 at 02:15:05PM -0800, Andrew Morton wrote:
>> > On Thu, 19 Feb 2009 14:31:17 +0200
>> > Felipe Balbi <me@felipebalbi.com> wrote:
>> >
>> > > +struct lm8323_platform_data {
>> > > + int debounce_time; /* Time to watch for key bouncing, in ms. */
>> > > + int active_time; /* Idle time until sleep, in ms. */
>> > > +
>> > > + int size_x;
>> > > + int size_y;
>> > > + int repeat : 1;
>> >
>> > lm8323_platform_data.repeat appears to be never-written-to?
>>
>> Nobody is using that yet, still it's used in the driver:
>> if (pdata->repeat)
>> __set_bit(EV_REP, idev->evbit);
>>
Thanks for addressing my review comments to this patch and of course Andrew's.
Happy to add
Reviewed-by: Trilok Soni <soni.trilok@gmail.com>
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
next prev parent reply other threads:[~2009-02-21 7:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 12:31 [PATCH] input: keyboard: introduce lm8323 driver Felipe Balbi
2009-02-20 22:15 ` Andrew Morton
2009-02-20 22:29 ` Felipe Balbi
2009-02-20 22:52 ` Felipe Balbi
2009-02-21 7:50 ` Trilok Soni [this message]
2009-02-20 22:54 ` Andrew Morton
2009-03-08 2:38 ` Dmitry Torokhov
2009-03-08 12:44 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5443650902202350p206e58ebvcd9becfd04a4133@mail.gmail.com \
--to=soni.trilok@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).