From: Trilok Soni <soni.trilok@gmail.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
dmitry.torokhov@gmail.com
Subject: Re: [PATCH] Input notifier support
Date: Thu, 26 Feb 2009 12:31:57 +0530 [thread overview]
Message-ID: <5d5443650902252301l19d08e67t54c1cea004442be2@mail.gmail.com> (raw)
In-Reply-To: <20090225044730.GA9106@july>
Hi Kyungmin,
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index 1730d73..7e96635 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -274,6 +274,8 @@ void input_event(struct input_dev *dev,
> add_input_randomness(type, code, value);
> input_handle_event(dev, type, code, value);
> spin_unlock_irqrestore(&dev->event_lock, flags);
> + if (type == EV_KEY)
> + input_notifier_call_chain(value, &code);
This check will be done for every input_report_xxx calls, even for
touchscreen events (in which case of course it will fail), and I don't
think this is optimal solution. Users should be given an option to
disable this if they don't need this notification mechanism.
How about moving this to input_report_key?
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-02-26 7:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 4:47 [PATCH] Input notifier support Kyungmin Park
2009-02-25 8:03 ` Trilok Soni
2009-02-25 9:55 ` Kyungmin Park
2009-02-26 7:01 ` Trilok Soni [this message]
2009-02-27 2:11 ` Kyungmin Park
2009-02-27 12:35 ` Trilok Soni
2009-02-28 22:30 ` Dmitry Torokhov
2009-02-28 23:34 ` Andi Kleen
2009-03-01 0:42 ` Dmitry Torokhov
2009-03-01 2:52 ` Kyungmin Park
2009-03-01 3:07 ` Dmitry Torokhov
2009-03-01 3:16 ` Kyungmin Park
2009-03-01 6:29 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5443650902252301l19d08e67t54c1cea004442be2@mail.gmail.com \
--to=soni.trilok@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kmpark@infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).