From: Trilok Soni <soni.trilok@gmail.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-input@vger.kernel.org, lethal@linux-sh.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] input: add suspend wakeup support to sh_keysc
Date: Tue, 10 Mar 2009 13:54:00 +0530 [thread overview]
Message-ID: <5d5443650903100124g2bbc4837gaa5d9a9f17cd56f0@mail.gmail.com> (raw)
In-Reply-To: <20090310062421.22328.68726.sendpatchset@rx1.opensource.se>
Hi Magnus,
> +
> + device_init_wakeup(&pdev->dev, 1);
> return 0;
Please add device_init_wakeup(&pdev->dev, 0) in sh_keysc_remove.
> err5:
> free_irq(irq, pdev);
> @@ -253,17 +255,36 @@ static int __devexit sh_keysc_remove(str
> return 0;
> }
>
> +static int sh_keysc_suspend(struct device *dev)
> +{
> + struct platform_device *pdev;
> + struct sh_keysc_priv *priv;
> + unsigned short value;
> +
> + pdev = container_of(dev, struct platform_device, dev);
> + priv = platform_get_drvdata(pdev);
to_platform_device(...) ?
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
next prev parent reply other threads:[~2009-03-10 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 6:24 [PATCH] input: add suspend wakeup support to sh_keysc Magnus Damm
2009-03-10 8:24 ` Trilok Soni [this message]
2009-03-10 10:01 ` Magnus Damm
2009-03-10 10:43 ` Trilok Soni
[not found] ` <aec7e5c30903100352o611e6cake0ddd50fed1d6975@mail.gmail.com>
2009-03-10 11:10 ` Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5443650903100124g2bbc4837gaa5d9a9f17cd56f0@mail.gmail.com \
--to=soni.trilok@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).