[PATCH 2/3] Matrix keypad

[PATCH 2/3] Matrix keypad

[Marek Vasut]

[-- Attachment #1: Type: text/plain, Size: 118 bytes --]

Hi,
this is the gpio driven matrix keypad. Final version.
I also CCed it to linux-input since it might interest them.

[-- Attachment #2: 09-matrix_keypad.patch --]
[-- Type: text/x-diff, Size: 11417 bytes --]

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index efd70a9..31b91ba 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -323,4 +323,14 @@ config KEYBOARD_SH_KEYSC
 
 	  To compile this driver as a module, choose M here: the
 	  module will be called sh_keysc.
+
+config KEYBOARD_MATRIX
+	tristate "GPIO driven matrix keypad support"
+	depends on GENERIC_GPIO
+	help
+	  Enable support for GPIO driven matrix keypad
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called matrix_keypad.
+
 endif
diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile
index 0edc8f2..b22bae1 100644
--- a/drivers/input/keyboard/Makefile
+++ b/drivers/input/keyboard/Makefile
@@ -27,3 +27,4 @@ obj-$(CONFIG_KEYBOARD_HP7XX)		+= jornada720_kbd.o
 obj-$(CONFIG_KEYBOARD_MAPLE)		+= maple_keyb.o
 obj-$(CONFIG_KEYBOARD_BFIN)		+= bf54x-keys.o
 obj-$(CONFIG_KEYBOARD_SH_KEYSC)		+= sh_keysc.o
+obj-$(CONFIG_KEYBOARD_MATRIX)		+= matrix_keypad.o
diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c
new file mode 100644
index 0000000..1a1503d
--- /dev/null
+++ b/drivers/input/keyboard/matrix_keypad.c
@@ -0,0 +1,351 @@
+/*
+ * drivers/input/keyboard/matrix_keypad.c
+ *
+ *  GPIO driven matrix keyboard driver
+ *
+ *  Copyright (c) 2008 Marek Vasut <marek.vasut@gmail.com>
+ *
+ *  Based on corgikbd.c
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License version 2 as
+ *  published by the Free Software Foundation.
+ *
+ */
+
+#include <linux/delay.h>
+#include <linux/platform_device.h>
+#include <linux/init.h>
+#include <linux/input.h>
+#include <linux/irq.h>
+#include <linux/interrupt.h>
+#include <linux/jiffies.h>
+#include <linux/module.h>
+#include <linux/gpio.h>
+#include <linux/matrix_keypad.h>
+
+struct matrix_keypad {
+	struct matrix_keypad_platform_data *pdata;
+	struct input_dev *input_dev;
+
+	spinlock_t lock;
+	struct timer_list timer;
+
+	unsigned int suspended;
+	unsigned long suspend_jiffies;
+
+	/* on, off, alt flags */
+	unsigned int size;
+	unsigned int *flags;
+};
+
+/*
+ * Get alternate function button status (if there is any on our keypad)
+ */
+static unsigned char matrix_keypad_get_fn(struct matrix_keypad *keypad)
+{
+	unsigned char fn = 0;
+	struct matrix_keypad_platform_data *pdata = keypad->pdata;
+
+	if (!pdata->alt_row || !pdata->alt_col)
+		return 0;
+
+	/* get the altfn key status */
+	gpio_set_value(pdata->row_gpio[pdata->alt_row],	!pdata->row_polarity);
+	udelay(50);
+	fn = !!gpio_get_value(pdata->col_gpio[pdata->alt_col]);
+	if (pdata->col_polarity)
+		fn = !fn;
+	gpio_set_value(pdata->row_gpio[pdata->alt_row],	pdata->row_polarity);
+	return fn;
+}
+
+/*
+ * Lookup the key in our keymap
+ */
+static unsigned int matrix_keypad_lookup(int row, int col,
+				struct matrix_keypad *keypad, int altfn)
+{
+	int i;
+	struct matrix_keypad_platform_data *pdata = keypad->pdata;
+
+	for (i = 0; i < pdata->map_size; i++)
+		if ((row == ((pdata->map[i]>>28) & 0xf)) &&
+		     (col == ((pdata->map[i]>>24) & 0xf)))
+			return (pdata->map[i] >> (12 * altfn)) & 0xfff;
+	return 0xfff;
+}
+
+/*
+ * This gets the keys from keyboard and reports it to input subsystem
+ */
+static void matrix_keypad_process(struct matrix_keypad *keypad)
+{
+	unsigned char fn = 0;
+	int i, j, pressed = 0;
+	unsigned long flags;
+	int gpio, key = 0;
+	struct matrix_keypad_platform_data *pdata = keypad->pdata;
+
+	spin_lock_irqsave(&keypad->lock, flags);
+
+	/* disable interrupts */
+	for (i = 0; i < pdata->col_gpio_size; i++)
+		set_irq_type(gpio_to_irq(pdata->col_gpio[i]),
+				IRQF_TRIGGER_NONE);
+
+	/* set all unreadable */
+	for (i = 0; i < pdata->row_gpio_size; i++)
+		gpio_set_value(pdata->row_gpio[i], pdata->row_polarity);
+
+	fn = matrix_keypad_get_fn(keypad);
+
+	/* read the keypad matrix */
+	for (i = 0; i < pdata->row_gpio_size; i++) {
+		gpio_set_value(pdata->row_gpio[i], !pdata->row_polarity);
+		udelay(50);
+		for (j = 0; j < pdata->col_gpio_size; j++) {
+				gpio = gpio_get_value(pdata->col_gpio[j]);
+				if (pdata->col_polarity)
+					gpio = !gpio;
+				if (gpio)
+					pressed++;
+				key = matrix_keypad_lookup(i, j, keypad, fn);
+				if (key == 0xfff)
+					continue;
+				if (gpio) {
+					input_report_key(keypad->input_dev,
+							key, 1);
+					keypad->flags[(key/32) + (keypad->size
+						* fn)] |= 1<<(key%32);
+				} else if ((keypad->flags[(key/32) +
+						(keypad->size * fn)] &
+						(1<<(key%32))) && !gpio) {
+					input_report_key(keypad->input_dev,
+							key, 0);
+					keypad->flags[(key/32) + (keypad->size
+						* fn)] &= ~(1<<(key%32));
+				}
+		}
+		gpio_set_value(pdata->row_gpio[i], pdata->row_polarity);
+		udelay(50);
+	}
+
+	/* set all readable */
+	for (i = 0; i < pdata->row_gpio_size; i++)
+		gpio_set_value(pdata->row_gpio[i],
+				!pdata->row_polarity);
+
+	/* reenable interrupts */
+	for (i = 0; i < pdata->col_gpio_size; i++)
+		set_irq_type(gpio_to_irq(pdata->col_gpio[i]),
+			    IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING);
+
+	/* report to input subsystem */
+	input_sync(keypad->input_dev);
+
+	/* if there were any new keypresses, handle repeats by rereading */
+	if (pressed)
+		mod_timer(&keypad->timer, jiffies + msecs_to_jiffies(
+				    pdata->debounce_interval));
+
+	spin_unlock_irqrestore(&keypad->lock, flags);
+}
+
+/*
+ * Interrupt handler
+ */
+static irqreturn_t matrix_keypad_interrupt(int irq, void *id)
+{
+	struct matrix_keypad *keypad = id;
+
+	if (!timer_pending(&keypad->timer)) {
+		udelay(20);
+		matrix_keypad_process(keypad);
+	}
+
+	return IRQ_HANDLED;
+}
+
+/*
+ * Timer checking for released keys and still held keys
+ */
+static void matrix_keypad_timer_callback(unsigned long data)
+{
+	struct matrix_keypad *keypad = (struct matrix_keypad *) data;
+	matrix_keypad_process(keypad);
+}
+
+#ifdef CONFIG_PM
+static int matrix_keypad_suspend(struct platform_device *dev,
+				pm_message_t state)
+{
+	int i;
+	struct matrix_keypad *keypad = platform_get_drvdata(dev);
+
+	keypad->suspended = 1;
+
+	/* we dont really want to suspend power key here */
+	for (i = 1; i < keypad->pdata->row_gpio_size; i++)
+		gpio_direction_input(keypad->pdata->row_gpio[i]);
+
+	return 0;
+}
+
+static int matrix_keypad_resume(struct platform_device *dev)
+{
+	int i;
+	struct matrix_keypad *keypad = platform_get_drvdata(dev);
+
+	/* Set strobe lines as outputs, low */
+	for (i = 0; i < keypad->pdata->row_gpio_size; i++)
+		gpio_direction_output(keypad->pdata->row_gpio[i], 0);
+
+	/* Upon resume, ignore the suspend key for a short while */
+	keypad->suspend_jiffies = jiffies;
+	keypad->suspended = 0;
+
+	return 0;
+}
+#else
+#define matrix_keypad_suspend	NULL
+#define matrix_keypad_resume	NULL
+#endif
+
+/*
+ * Everything starts here
+ */
+static int __init matrix_keypad_probe(struct platform_device *pdev)
+{
+	struct matrix_keypad *keypad;
+	struct input_dev *input_dev;
+	int i, err = -ENOMEM;
+
+	keypad = kzalloc(sizeof(struct matrix_keypad), GFP_KERNEL);
+	input_dev = input_allocate_device();
+	if (!keypad || !input_dev)
+		goto fail;
+
+	platform_set_drvdata(pdev, keypad);
+
+	keypad->input_dev = input_dev;
+	keypad->pdata = pdev->dev.platform_data;
+	keypad->size = (keypad->pdata->map_size / sizeof(unsigned int))+1;
+	keypad->flags = kzalloc(2 * keypad->size, GFP_KERNEL);
+	if (!keypad->flags)
+		goto fail;
+
+	spin_lock_init(&keypad->lock);
+
+	/* Init Keyboard rescan timer */
+	init_timer(&keypad->timer);
+	keypad->timer.function = matrix_keypad_timer_callback;
+	keypad->timer.data = (unsigned long) keypad;
+
+	keypad->suspend_jiffies = jiffies;
+
+	input_dev->name = pdev->name;
+	input_dev->id.bustype = BUS_HOST;
+	input_dev->dev.parent = &pdev->dev;
+
+	input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP) |
+		BIT_MASK(EV_PWR) | BIT_MASK(EV_SW);
+	input_dev->keycodesize = sizeof(unsigned int);
+
+	for (i = 0; i < keypad->pdata->map_size; i++) {
+		if ((keypad->pdata->map[i] & 0xfff) != 0xfff)
+			set_bit((keypad->pdata->map[i] & 0xfff),
+				input_dev->keybit);
+		if (((keypad->pdata->map[i] >> 12) & 0xfff) != 0xfff)
+			set_bit((keypad->pdata->map[i] >> 12) & 0xfff,
+				input_dev->keybit);
+	}
+
+	err = input_register_device(keypad->input_dev);
+	if (err)
+		goto fail;
+
+	for (i = 0; i < keypad->pdata->col_gpio_size; i++) {
+		gpio_direction_input(keypad->pdata->col_gpio[i]);
+		if (request_irq(gpio_to_irq(keypad->pdata->col_gpio[i]),
+				matrix_keypad_interrupt, IRQF_DISABLED |
+				IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
+				"matrix-keypad", keypad))
+			printk(KERN_ERR "Unable to acquire interrupt"
+				" for GPIO line %i\n",
+				keypad->pdata->col_gpio[i]);
+	}
+
+	/* Set strobe lines as outputs, low */
+	for (i = 0; i < keypad->pdata->row_gpio_size; i++) {
+		err = gpio_request(keypad->pdata->row_gpio[i],
+				    "KBD_LINE");
+		if (err)
+			goto gpio_err;
+		gpio_direction_output(keypad->pdata->row_gpio[i], 0);
+	}
+
+	return 0;
+
+gpio_err:
+	for (i = i-1; i >= 0; i--)
+		gpio_free(keypad->pdata->row_gpio[i]);
+
+fail:	input_free_device(input_dev);
+	kfree(keypad);
+	return err;
+}
+
+/*
+ * Everything ends here
+ */
+static int matrix_keypad_remove(struct platform_device *pdev)
+{
+	int i;
+	struct matrix_keypad *keypad = platform_get_drvdata(pdev);
+
+	for (i = 0; i < keypad->pdata->col_gpio_size; i++)
+		free_irq(gpio_to_irq(keypad->pdata->col_gpio[i]),
+				    keypad);
+
+	for (i = 0; i < keypad->pdata->row_gpio_size; i++)
+		gpio_free(keypad->pdata->row_gpio[i]);
+
+	del_timer_sync(&keypad->timer);
+
+	input_unregister_device(keypad->input_dev);
+
+	kfree(keypad->flags);
+	kfree(keypad);
+
+	return 0;
+}
+
+static struct platform_driver matrix_keypad_driver = {
+	.probe		= matrix_keypad_probe,
+	.remove		= matrix_keypad_remove,
+	.suspend	= matrix_keypad_suspend,
+	.resume		= matrix_keypad_resume,
+	.driver		= {
+		.name	= "matrix-keypad",
+		.owner	= THIS_MODULE,
+	},
+};
+
+static int __devinit matrix_keypad_init(void)
+{
+	return platform_driver_register(&matrix_keypad_driver);
+}
+
+static void __exit matrix_keypad_exit(void)
+{
+	platform_driver_unregister(&matrix_keypad_driver);
+}
+
+module_init(matrix_keypad_init);
+module_exit(matrix_keypad_exit);
+
+MODULE_AUTHOR("Marek Vasut <marek.vasut@gmail.com>");
+MODULE_DESCRIPTION("GPIO Driven Matrix Keypad Driver");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:matrix-keypad");
diff --git a/include/linux/matrix_keypad.h b/include/linux/matrix_keypad.h
new file mode 100644
index 0000000..fe72721
--- /dev/null
+++ b/include/linux/matrix_keypad.h
@@ -0,0 +1,35 @@
+#ifndef _MATRIX_KEYPAD_H
+#define _MATRIX_KEYPAD_H
+
+#include <linux/input.h>
+
+struct matrix_keypad_platform_data {
+
+	/* code map for the matrix keys */
+	unsigned int	*map;
+	int		map_size;
+
+	unsigned int	*col_gpio;
+	int		col_gpio_size;
+	unsigned int	*row_gpio;
+	int		row_gpio_size;
+
+	/* ALTFN key */
+	int		alt_row;
+	int		alt_col;
+
+	/* line polarities */
+	unsigned int	col_polarity;
+	unsigned int	row_polarity;
+
+	/* key debounce interval */
+	unsigned int	debounce_interval;
+};
+
+#define KEY(row, col, val, alt)	(((row) << 28) | ((col) << 24) | \
+				((alt & 0xfff) << 12) | (val & 0xfff))
+
+/* key not connected */
+#define KEY_NC	0xfff
+
+#endif /* _MATRIX_KEYPAD_H */

Re: [PATCH 2/3] Matrix keypad

[Trilok Soni]

Hi Marek Vasut,

On Wed, Jul 9, 2008 at 7:11 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Hi,
> this is the gpio driven matrix keypad. Final version.
> I also CCed it to linux-input since it might interest them.

Is there any interest for this patch to get mainlined through input subsystem ?

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni

Re: [PATCH 2/3] Matrix keypad

[Marek Vasut]

On Tuesday 07 of April 2009 13:37:50 Trilok Soni wrote:
> Hi Marek Vasut,
>
> On Wed, Jul 9, 2008 at 7:11 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > Hi,
> > this is the gpio driven matrix keypad. Final version.
> > I also CCed it to linux-input since it might interest them.
>
> Is there any interest for this patch to get mainlined through input
> subsystem ?

Yes, I'd like to see it mainlined as I need it on some devices. I haven't 
gotten to rewriting it as Dmitry Torokhov requested me to (see his reply in 
linux-input) though.

Re: [PATCH 2/3] Matrix keypad

[Trilok Soni]

Hi Marek,

On Tue, Apr 7, 2009 at 6:46 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> On Tuesday 07 of April 2009 13:37:50 Trilok Soni wrote:
>> Hi Marek Vasut,
>>
>> On Wed, Jul 9, 2008 at 7:11 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> > Hi,
>> > this is the gpio driven matrix keypad. Final version.
>> > I also CCed it to linux-input since it might interest them.
>>
>> Is there any interest for this patch to get mainlined through input
>> subsystem ?
>
> Yes, I'd like to see it mainlined as I need it on some devices. I haven't
> gotten to rewriting it as Dmitry Torokhov requested me to (see his reply in
> linux-input) though.
>

I found only this thread where Dmitry Baryshkov had given some comments.

http://marc.info/?t=121732956800006&r=1&w=2

AFAIK, there is no need to give irqf_sample_random for input drivers
interrupts, as it is already done by input subsystem. Could you please
point to the exact thread where Dmitry Torokhov commented?


-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni

Re: [PATCH 2/3] Matrix keypad

[Marek Vasut]

On Tuesday 07 of April 2009 15:41:05 Trilok Soni wrote:
> Hi Marek,
>
> On Tue, Apr 7, 2009 at 6:46 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > On Tuesday 07 of April 2009 13:37:50 Trilok Soni wrote:
> >> Hi Marek Vasut,
> >>
> >> On Wed, Jul 9, 2008 at 7:11 AM, Marek Vasut <marek.vasut@gmail.com> 
wrote:
> >> > Hi,
> >> > this is the gpio driven matrix keypad. Final version.
> >> > I also CCed it to linux-input since it might interest them.
> >>
> >> Is there any interest for this patch to get mainlined through input
> >> subsystem ?
> >
> > Yes, I'd like to see it mainlined as I need it on some devices. I haven't
> > gotten to rewriting it as Dmitry Torokhov requested me to (see his reply
> > in linux-input) though.
>
> I found only this thread where Dmitry Baryshkov had given some comments.
>
> http://marc.info/?t=121732956800006&r=1&w=2
>
> AFAIK, there is no need to give irqf_sample_random for input drivers
> interrupts, as it is already done by input subsystem. Could you please
> point to the exact thread where Dmitry Torokhov commented?

http://article.gmane.org/gmane.linux.kernel.input/5551 try here

Re: [PATCH 2/3] Matrix keypad

[Marek Vasut]

On Tuesday 07 of April 2009 15:59:59 Marek Vasut wrote:
> On Tuesday 07 of April 2009 15:41:05 Trilok Soni wrote:
> > Hi Marek,
> >
> > On Tue, Apr 7, 2009 at 6:46 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > > On Tuesday 07 of April 2009 13:37:50 Trilok Soni wrote:
> > >> Hi Marek Vasut,
> > >>
> > >> On Wed, Jul 9, 2008 at 7:11 AM, Marek Vasut <marek.vasut@gmail.com>
>
> wrote:
> > >> > Hi,
> > >> > this is the gpio driven matrix keypad. Final version.
> > >> > I also CCed it to linux-input since it might interest them.
> > >>
> > >> Is there any interest for this patch to get mainlined through input
> > >> subsystem ?
> > >
> > > Yes, I'd like to see it mainlined as I need it on some devices. I
> > > haven't gotten to rewriting it as Dmitry Torokhov requested me to (see
> > > his reply in linux-input) though.
> >
> > I found only this thread where Dmitry Baryshkov had given some comments.
> >
> > http://marc.info/?t=121732956800006&r=1&w=2
> >
> > AFAIK, there is no need to give irqf_sample_random for input drivers
> > interrupts, as it is already done by input subsystem. Could you please
> > point to the exact thread where Dmitry Torokhov commented?
>
> http://article.gmane.org/gmane.linux.kernel.input/5551 try here

just wondering ... do you need that driver or something ? or are you willing 
to do the final fixes ? :)

Re: [PATCH 2/3] Matrix keypad

[Eric Miao]

On Fri, Apr 10, 2009 at 12:57 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> On Tuesday 07 of April 2009 15:59:59 Marek Vasut wrote:
>> On Tuesday 07 of April 2009 15:41:05 Trilok Soni wrote:
>> > Hi Marek,
>> >
>> > On Tue, Apr 7, 2009 at 6:46 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> > > On Tuesday 07 of April 2009 13:37:50 Trilok Soni wrote:
>> > >> Hi Marek Vasut,
>> > >>
>> > >> On Wed, Jul 9, 2008 at 7:11 AM, Marek Vasut <marek.vasut@gmail.com>
>>
>> wrote:
>> > >> > Hi,
>> > >> > this is the gpio driven matrix keypad. Final version.
>> > >> > I also CCed it to linux-input since it might interest them.
>> > >>
>> > >> Is there any interest for this patch to get mainlined through input
>> > >> subsystem ?
>> > >
>> > > Yes, I'd like to see it mainlined as I need it on some devices. I
>> > > haven't gotten to rewriting it as Dmitry Torokhov requested me to (see
>> > > his reply in linux-input) though.
>> >
>> > I found only this thread where Dmitry Baryshkov had given some comments.
>> >
>> > http://marc.info/?t=121732956800006&r=1&w=2
>> >
>> > AFAIK, there is no need to give irqf_sample_random for input drivers
>> > interrupts, as it is already done by input subsystem. Could you please
>> > point to the exact thread where Dmitry Torokhov commented?
>>
>> http://article.gmane.org/gmane.linux.kernel.input/5551 try here
>
> just wondering ... do you need that driver or something ? or are you willing
> to do the final fixes ? :)

I'll take a look into this. I need this driver to deprecate the original
corgi/poodle keyboard driver, which causes a lot of ugly warnings.

Re: [PATCH 2/3] Matrix keypad

[Marek Vasut]

On Friday 10 of April 2009 06:19:09 Eric Miao wrote:
> On Fri, Apr 10, 2009 at 12:57 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > On Tuesday 07 of April 2009 15:59:59 Marek Vasut wrote:
> >> On Tuesday 07 of April 2009 15:41:05 Trilok Soni wrote:
> >> > Hi Marek,
> >> >
> >> > On Tue, Apr 7, 2009 at 6:46 PM, Marek Vasut <marek.vasut@gmail.com> 
wrote:
> >> > > On Tuesday 07 of April 2009 13:37:50 Trilok Soni wrote:
> >> > >> Hi Marek Vasut,
> >> > >>
> >> > >> On Wed, Jul 9, 2008 at 7:11 AM, Marek Vasut <marek.vasut@gmail.com>
> >>
> >> wrote:
> >> > >> > Hi,
> >> > >> > this is the gpio driven matrix keypad. Final version.
> >> > >> > I also CCed it to linux-input since it might interest them.
> >> > >>
> >> > >> Is there any interest for this patch to get mainlined through input
> >> > >> subsystem ?
> >> > >
> >> > > Yes, I'd like to see it mainlined as I need it on some devices. I
> >> > > haven't gotten to rewriting it as Dmitry Torokhov requested me to
> >> > > (see his reply in linux-input) though.
> >> >
> >> > I found only this thread where Dmitry Baryshkov had given some
> >> > comments.
> >> >
> >> > http://marc.info/?t=121732956800006&r=1&w=2
> >> >
> >> > AFAIK, there is no need to give irqf_sample_random for input drivers
> >> > interrupts, as it is already done by input subsystem. Could you please
> >> > point to the exact thread where Dmitry Torokhov commented?
> >>
> >> http://article.gmane.org/gmane.linux.kernel.input/5551 try here
> >
> > just wondering ... do you need that driver or something ? or are you
> > willing to do the final fixes ? :)
>
> I'll take a look into this. I need this driver to deprecate the original
> corgi/poodle keyboard driver, which causes a lot of ugly warnings.

That'd be great, I need it on two devices too. I'm a little frightened about 
it's speed though as it's iterating over all the GPIOs, but there is a 
possibility to read a whole bunch of GPIOs at one time now, right ?

Re: [PATCH 2/3] Matrix keypad

[Eric Miao]

On Fri, Apr 10, 2009 at 1:52 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> On Friday 10 of April 2009 06:19:09 Eric Miao wrote:
>> On Fri, Apr 10, 2009 at 12:57 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> > On Tuesday 07 of April 2009 15:59:59 Marek Vasut wrote:
>> >> On Tuesday 07 of April 2009 15:41:05 Trilok Soni wrote:
>> >> > Hi Marek,
>> >> >
>> >> > On Tue, Apr 7, 2009 at 6:46 PM, Marek Vasut <marek.vasut@gmail.com>
> wrote:
>> >> > > On Tuesday 07 of April 2009 13:37:50 Trilok Soni wrote:
>> >> > >> Hi Marek Vasut,
>> >> > >>
>> >> > >> On Wed, Jul 9, 2008 at 7:11 AM, Marek Vasut <marek.vasut@gmail.com>
>> >>
>> >> wrote:
>> >> > >> > Hi,
>> >> > >> > this is the gpio driven matrix keypad. Final version.
>> >> > >> > I also CCed it to linux-input since it might interest them.
>> >> > >>
>> >> > >> Is there any interest for this patch to get mainlined through input
>> >> > >> subsystem ?
>> >> > >
>> >> > > Yes, I'd like to see it mainlined as I need it on some devices. I
>> >> > > haven't gotten to rewriting it as Dmitry Torokhov requested me to
>> >> > > (see his reply in linux-input) though.
>> >> >
>> >> > I found only this thread where Dmitry Baryshkov had given some
>> >> > comments.
>> >> >
>> >> > http://marc.info/?t=121732956800006&r=1&w=2
>> >> >
>> >> > AFAIK, there is no need to give irqf_sample_random for input drivers
>> >> > interrupts, as it is already done by input subsystem. Could you please
>> >> > point to the exact thread where Dmitry Torokhov commented?
>> >>
>> >> http://article.gmane.org/gmane.linux.kernel.input/5551 try here
>> >
>> > just wondering ... do you need that driver or something ? or are you
>> > willing to do the final fixes ? :)
>>
>> I'll take a look into this. I need this driver to deprecate the original
>> corgi/poodle keyboard driver, which causes a lot of ugly warnings.
>
> That'd be great, I need it on two devices too. I'm a little frightened about
> it's speed though as it's iterating over all the GPIOs, but there is a
> possibility to read a whole bunch of GPIOs at one time now, right ?
>

I'm not sure if Jaya Kumar's batch gpio patches have been merged or
not. Performance should not be that sensitive for keypad :)

-- 
Cheers
- eric

Re: [PATCH 2/3] Matrix keypad

[Trilok Soni]

Hi Marek,

On Thu, Apr 9, 2009 at 10:27 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> On Tuesday 07 of April 2009 15:59:59 Marek Vasut wrote:
>> On Tuesday 07 of April 2009 15:41:05 Trilok Soni wrote:
>> > Hi Marek,
>> >
>> > On Tue, Apr 7, 2009 at 6:46 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> > > On Tuesday 07 of April 2009 13:37:50 Trilok Soni wrote:
>> > >> Hi Marek Vasut,
>> > >>
>> > >> On Wed, Jul 9, 2008 at 7:11 AM, Marek Vasut <marek.vasut@gmail.com>
>>
>> wrote:
>> > >> > Hi,
>> > >> > this is the gpio driven matrix keypad. Final version.
>> > >> > I also CCed it to linux-input since it might interest them.
>> > >>
>> > >> Is there any interest for this patch to get mainlined through input
>> > >> subsystem ?
>> > >
>> > > Yes, I'd like to see it mainlined as I need it on some devices. I
>> > > haven't gotten to rewriting it as Dmitry Torokhov requested me to (see
>> > > his reply in linux-input) though.
>> >
>> > I found only this thread where Dmitry Baryshkov had given some comments.
>> >
>> > http://marc.info/?t=121732956800006&r=1&w=2
>> >
>> > AFAIK, there is no need to give irqf_sample_random for input drivers
>> > interrupts, as it is already done by input subsystem. Could you please
>> > point to the exact thread where Dmitry Torokhov commented?
>>
>> http://article.gmane.org/gmane.linux.kernel.input/5551 try here
>
> just wondering ... do you need that driver or something ? or are you willing
> to do the final fixes ? :)
>

Actually both as time permits.

1. input_polldev support for gpios which can't be configured for irqs
2. hopefully removing kthread with timer

I was also comparing this driver with one written for matrix gpio
keypad in android-msm-kernel. You might want to have look at it.

gpio_matrix.c:

http://android.git.kernel.org/?p=kernel/msm.git;a=blob;f=drivers/input/misc/gpio_matrix.c;h=c1f47651a4937d5c976a9625ca5da389dd7e4a7c;hb=HEAD

gpio_input.c:

http://android.git.kernel.org/?p=kernel/msm.git;a=blob;f=drivers/input/misc/gpio_input.c;h=7e307f267a2a059b64a3fb9c8a379b149016b2f8;hb=HEAD


-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni