From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trilok Soni Subject: Re: [PATCH 2/3] Matrix keypad Date: Fri, 10 Apr 2009 21:36:16 +0530 Message-ID: <5d5443650904100906k49c7bd33ye27ee1c1a4ef6de5@mail.gmail.com> References: <200807090341.20397.marek.vasut@gmail.com> <5d5443650904070641w49ff0a3fo4826833d21032a02@mail.gmail.com> <200904071559.59668.marek.vasut@gmail.com> <200904091857.27054.marek.vasut@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wf-out-1314.google.com ([209.85.200.168]:46330 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762574AbZDJQGR (ORCPT ); Fri, 10 Apr 2009 12:06:17 -0400 Received: by wf-out-1314.google.com with SMTP id 29so1129592wff.4 for ; Fri, 10 Apr 2009 09:06:16 -0700 (PDT) In-Reply-To: <200904091857.27054.marek.vasut@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Marek Vasut Cc: linux-arm-kernel@lists.arm.linux.org.uk, Dmitry Torokhov , Russell King - ARM Linux , linux-input@vger.kernel.org Hi Marek, On Thu, Apr 9, 2009 at 10:27 PM, Marek Vasut wrote: > On Tuesday 07 of April 2009 15:59:59 Marek Vasut wrote: >> On Tuesday 07 of April 2009 15:41:05 Trilok Soni wrote: >> > Hi Marek, >> > >> > On Tue, Apr 7, 2009 at 6:46 PM, Marek Vasut wrote: >> > > On Tuesday 07 of April 2009 13:37:50 Trilok Soni wrote: >> > >> Hi Marek Vasut, >> > >> >> > >> On Wed, Jul 9, 2008 at 7:11 AM, Marek Vasut >> >> wrote: >> > >> > Hi, >> > >> > this is the gpio driven matrix keypad. Final version. >> > >> > I also CCed it to linux-input since it might interest them. >> > >> >> > >> Is there any interest for this patch to get mainlined through input >> > >> subsystem ? >> > > >> > > Yes, I'd like to see it mainlined as I need it on some devices. I >> > > haven't gotten to rewriting it as Dmitry Torokhov requested me to (see >> > > his reply in linux-input) though. >> > >> > I found only this thread where Dmitry Baryshkov had given some comments. >> > >> > http://marc.info/?t=121732956800006&r=1&w=2 >> > >> > AFAIK, there is no need to give irqf_sample_random for input drivers >> > interrupts, as it is already done by input subsystem. Could you please >> > point to the exact thread where Dmitry Torokhov commented? >> >> http://article.gmane.org/gmane.linux.kernel.input/5551 try here > > just wondering ... do you need that driver or something ? or are you willing > to do the final fixes ? :) > Actually both as time permits. 1. input_polldev support for gpios which can't be configured for irqs 2. hopefully removing kthread with timer I was also comparing this driver with one written for matrix gpio keypad in android-msm-kernel. You might want to have look at it. gpio_matrix.c: http://android.git.kernel.org/?p=kernel/msm.git;a=blob;f=drivers/input/misc/gpio_matrix.c;h=c1f47651a4937d5c976a9625ca5da389dd7e4a7c;hb=HEAD gpio_input.c: http://android.git.kernel.org/?p=kernel/msm.git;a=blob;f=drivers/input/misc/gpio_input.c;h=7e307f267a2a059b64a3fb9c8a379b149016b2f8;hb=HEAD -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni