From: Trilok Soni <soni.trilok@gmail.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Kwangwoo Lee <kwangwoo.lee@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] input: Add support for the TSC2003 controller.
Date: Mon, 4 May 2009 17:33:56 +0530 [thread overview]
Message-ID: <5d5443650905040503n501e3b47qc890dc4c71a85b1c@mail.gmail.com> (raw)
In-Reply-To: <20090504113751.GA22603@avionic-design.de>
Hi Thierry,
On Mon, May 4, 2009 at 5:07 PM, Thierry Reding
<thierry.reding@avionic-design.de> wrote:
> * Kwangwoo Lee wrote:
>> Hi Thierry and Trilok,
>>
>> On Wed, Apr 29, 2009 at 10:23 PM, Trilok Soni <soni.trilok@gmail.com> wrote:
>> > Hi Thierry,
>> >
>> > I have added linux-omap community. How different is this chip from
>> > tsc2007. It looks to me that this chip is not much different from
>> > tsc2007 (this is just quick look at the driver). If they
>> > are similar please consider using i2c_device_id feature in tsc2007 to
>> > accommodate this chip.
>>
>> I agree with the Trilok's opinion.
> [snip]
>
> I only noticed the tsc2007 driver some time ago, when the tsc2003 was already
> finished (it's actually pretty old, I just never got around to submitting
> it). However I never got the tsc2007 to work on my platform because it uses
> sleeping functions inside the timer handler, which results in an oops right
> after the first touchscreen interrupt.
>
> I guess I could try and fix the tsc2007 properly instead of having a second,
> pretty similar driver in the tree.
>
This could be because of improper locking? If you share a crash we can
have look at it.
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
next prev parent reply other threads:[~2009-05-04 12:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 12:03 [PATCH] input: Add support for the TSC2003 controller Thierry Reding
2009-04-29 13:23 ` Trilok Soni
2009-04-30 1:35 ` Kwangwoo Lee
2009-05-04 11:37 ` Thierry Reding
2009-05-04 12:03 ` Trilok Soni [this message]
2009-05-04 14:57 ` Thierry Reding
2009-05-04 17:21 ` Trilok Soni
2009-05-05 6:22 ` Thierry Reding
2009-05-06 4:28 ` Kwangwoo Lee
2009-05-06 4:25 ` Kwangwoo Lee
2009-05-06 6:45 ` Thierry Reding
2009-05-06 6:54 ` Kwangwoo Lee
2009-05-06 11:13 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5443650905040503n501e3b47qc890dc4c71a85b1c@mail.gmail.com \
--to=soni.trilok@gmail.com \
--cc=kwangwoo.lee@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).