Re: [PATCH] input: add support for generic GPIO-based matrix keypad

[Trilok Soni <soni.trilok@gmail.com>]

Hi Dmitry,

>
> Input: add support for generic GPIO-based matrix keypad
>
> From: Eric Miao <eric.y.miao@gmail.com>
>
> Original patch by Marek Vasut, modified by Eric in:
>
> 1. use delayed work to simplify the debouncing
> 2. combine col_polarity/row_polarity into a single active_low field
> 3. use a generic bit array based XOR algorithm to detect key
>   press/release, which should make the column assertion time
>   shorter and code a bit cleaner
> 4. remove the ALT_FN handling, which is no way generic, the ALT_FN
>   key should be treated as no different from other keys, and
>   translation will be done by user space by commands like 'loadkeys'.
>
> [dtor@mail.ru: fix error unwinding path, support changing keymap
>  from userspace]
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Signed-off-by: Eric Miao <eric.miao@marvell.com>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> ---

Did you took latest patch submitted from Eric? Because it had more
signed-off and acked-by lines, like this.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Reviewed-by: Trilok Soni <soni.trilok@gmail.com>
Reviewed-by: Uli Luckas <u.luckas@road.de>
Reviewed-by: Russell King <linux@arm.linux.org.uk>
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Eric Miao <eric.miao@marvell.com>

http://markmail.org/message/2wrr2b6mr6qsd4xs#query:+page:1+mid:fkkfxlumfm4mjhk4+state:results

Eric can confirm otherwise.

>
>  config KEYBOARD_HIL_OLD
>        tristate "HP HIL keyboard support (simple driver)"
> @@ -254,7 +263,7 @@ config KEYBOARD_PXA27x
>        tristate "PXA27x/PXA3xx keypad support"
>        depends on PXA27x || PXA3xx
>        help
> -         Enable support for PXA27x/PXA3xx keypad controller
> +         Enable support for PXA27x/PXA3xx keypad controller.

Why this change in this patch?

> +
> +                       code = (row << 4) + col;

<< 4 logic will break once MAX_ROWS increased, right?


-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html