From: Trilok Soni <soni.trilok@gmail.com>
To: Wan ZongShun <mcuos.com@gmail.com>
Cc: linux-input@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] input:Add clk api support for w90p910 touchscreen
Date: Tue, 7 Jul 2009 22:49:52 +0530 [thread overview]
Message-ID: <5d5443650907071019w45474b2dhd0a175a0ffac4f3a@mail.gmail.com> (raw)
In-Reply-To: <4A535B97.4010700@gmail.com>
Hi,
> + w90p910_ts->clk = clk_get(&pdev->dev, pdev->name);
Having clk_name coming from pdev->name looks strange to me. I feel it
should either "NULL" or const string.
> + if (IS_ERR(w90p910_ts->clk)) {
> + err = PTR_ERR(w90p910_ts->clk);
> goto fail3;
> }
>
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-07-07 17:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 14:28 [PATCH] input:Add clk api support for w90p910 touchscreen Wan ZongShun
2009-07-07 17:19 ` Trilok Soni [this message]
2009-07-08 5:22 ` Wan ZongShun
2009-07-08 6:51 ` Dmitry Torokhov
2009-07-08 7:10 ` Wan ZongShun
2009-07-08 10:34 ` Trilok Soni
2009-07-08 14:06 ` Wan ZongShun
2009-07-08 14:21 ` Trilok Soni
2009-07-08 14:31 ` Wan ZongShun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5443650907071019w45474b2dhd0a175a0ffac4f3a@mail.gmail.com \
--to=soni.trilok@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=mcuos.com@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).