From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trilok Soni Subject: Re: [PATCHv2 0/3] Add support for TCA6416 based Keypad driver. Date: Sat, 13 Mar 2010 02:08:20 +0530 Message-ID: <5d5443651003121238l7fb1c5b1rbcbea660c5cf83c@mail.gmail.com> References: <1268385499-7075-1-git-send-email-srk@ti.com> <6ed0b2681003120323r2a1b72a9m344d71431ebcd7c4@mail.gmail.com> <20100312172943.GH2900@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <20100312172943.GH2900@atomide.com> Sender: linux-omap-owner@vger.kernel.org To: Tony Lindgren Cc: "Govindarajan, Sriramakrishnan" , Grazvydas Ignotas , "linux-omap@vger.kernel.org" , "linux-input@vger.kernel.org" List-Id: linux-input@vger.kernel.org Hi, On Fri, Mar 12, 2010 at 10:59 PM, Tony Lindgren wrote: > * Govindarajan, Sriramakrishnan [100312 03:39]: >> >> > Please fix mode - remove +x flags. >> >> [Sriram] Thanks for pointing out. I will await further review comments >> And post the updated version thereafter > > Please fix mode change issue at TI in general. > > We're getting these executable mode change patches from TI on regular basis. > Better way to add checking +x attribute support internally in checkpatch.pl and let everybody scan through checkpatch.pl before submitting a patch to ML. It works !!! -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni