Linux Input/HID development
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: John Keeping <jkeeping@inmusicbrands.com>,
	linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] Input: ili210x - fix ili251x_read_touch_data() return value
Date: Wed, 22 May 2024 22:25:17 +0200	[thread overview]
Message-ID: <5ed339a9-82cb-403d-92fd-fdcb18653f72@web.de> (raw)
In-Reply-To: <20240522100341.1650842-1-jkeeping@inmusicbrands.com>

…
> This fixes touch reporting when there are more than 6 active touches.

Does such information indicate a need for the tag “Fixes”?


…
> +++ b/drivers/input/touchscreen/ili210x.c
> @@ -255,14 +255,15 @@ static int ili251x_read_reg(struct i2c_client *client,
>  static int ili251x_read_touch_data(struct i2c_client *client, u8 *data)
>  {
>  	int error;
> +	int ret;
>
>  	error = ili251x_read_reg_common(client, REG_TOUCHDATA,
>  					data, ILI251X_DATA_SIZE1, 0);
>  	if (!error && data[0] == 2) {
…

I suggest to define the variable “ret” in the shown if branch.

Regards,
Markus

      parent reply	other threads:[~2024-05-22 20:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 10:03 [PATCH] Input: ili210x - fix ili251x_read_touch_data() return value John Keeping
2024-05-22 19:28 ` Dmitry Torokhov
2024-05-22 20:25 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ed339a9-82cb-403d-92fd-fdcb18653f72@web.de \
    --to=markus.elfring@web.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkeeping@inmusicbrands.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox