Re: [PATCH v13 1/3] HID: nintendo: Add preliminary Switch 2 controller driver

[Vicki Pfau <vi@endrift.com>]

Hi Benjamin,

On 9/22/26 8:20 AM, Benjamin Tissoires wrote:
> Hi Vicki,
> 
> On Sep 14 2026, Vicki Pfau wrote:
>> Dmitry,
>>
>> Can you please review the USB portion of this patch? I've been submitting drafts since December and you've yet to review it. This series has been ready for a month and I don't want to miss another merge window.
> 
> Looking further more into drivers/input/joystick/nintendo-switch2-usb.c,
> and correct me if I'm wrong, but that file doesn't seem to use any input
> related API. And given that it's sharing a struct with HID, I wonder in
> the end if you should not move this file in drivers/hid/ instead. Jiri
> might have a different view, but I think we can make an exception given
> that this is a requirement for the HID part to work correctly.
> 
> This would remove the pain of multi-subsystems handling.

I can do that. It's a pure USB module so I had assumed it was ill-fitting in the hid directory, but it is solely for the operation of a hid driver so I guess it makes sense. Nintendo Switch 2 controllers have two interfaces over USB: a standard HID one and a sidechannel it uses bulk transfers on to do configuration. There's a similar sidechannel over Bluetooth, but that's future work.

I'll prepare a v14 when I have time. There's a third party controller I want to take a look at too; the right joy-con works with this series, but the left doesn't. Very strange.
> 
> Cheers,
> Benjamin
> 

Vicki