From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Joel Selvaraj <joelselvaraj.oss@gmail.com>,
Caleb Connolly <caleb@connolly.tech>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Henrik Rydberg <rydberg@bitmath.org>,
Arnd Bergmann <arnd@arndb.de>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Jeff LaBundy <jeff@labundy.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Markuss Broks <markuss.broks@gmail.com>,
Jean Delvare <jdelvare@suse.de>,
Max Krummenacher <max.krummenacher@toradex.com>,
Job Noorman <job@noorman.info>,
Alistair Francis <alistair@alistair23.me>,
Chris Morgan <macromorgan@hotmail.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 5/5] arm64: dts: qcom: sdm845-shift-axolotl: update focaltech touchscreen properties
Date: Sun, 12 Mar 2023 21:49:31 +0100 [thread overview]
Message-ID: <62c20bd9-8f24-c226-1786-40bb20d95644@linaro.org> (raw)
In-Reply-To: <20230312093249.1846993-6-joelselvaraj.oss@gmail.com>
On 12/03/2023 10:32, Joel Selvaraj wrote:
> The touchscreen nodes were added before the driver patches were merged.
> Update the focaltech touchscreen properties to match with the upstreamed
> focaltech driver. Also, the touchscreen used is in axolotl is fts5452
> and not fts8719.
>
> Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>
> ---
> .../boot/dts/qcom/sdm845-shift-axolotl.dts | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> index b54e304abf71..39f59ee3612a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> @@ -473,21 +473,22 @@ zap-shader {
> &i2c5 {
> status = "okay";
>
> - touchscreen@38 {
> - compatible = "focaltech,fts8719";
> + touchscreen: focaltech@38 {
So you had good name and you replace it to something wrong... Drop the
label. This actually applies to all other patches, unless you need it.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-03-12 20:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 9:32 [PATCH 0/5] Add support for Focaltech FTS Touchscreen Joel Selvaraj
2023-03-12 9:32 ` [PATCH 1/5] dt-bindings: input: touchscreen: add bindings for focaltech,fts Joel Selvaraj
2023-03-12 20:47 ` Krzysztof Kozlowski
2023-03-13 0:21 ` Joel Selvaraj
2023-03-13 6:42 ` Krzysztof Kozlowski
2023-03-13 6:53 ` Joel Selvaraj
2023-03-14 14:10 ` Rob Herring
2023-03-12 9:32 ` [PATCH 2/5] Input: add driver for Focaltech FTS touchscreen Joel Selvaraj
2023-03-12 20:40 ` Markuss Broks
2023-03-12 22:21 ` Joel Selvaraj
2023-04-09 13:32 ` Markuss Broks
2023-04-09 14:24 ` Joel Selvaraj
2023-03-14 3:42 ` Jeff LaBundy
2023-03-14 4:33 ` Joel Selvaraj
2023-03-12 9:32 ` [PATCH 3/5] arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes Joel Selvaraj
2023-03-12 9:32 ` [PATCH 4/5] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce support for fts touchscreen Joel Selvaraj
2023-03-12 20:48 ` Krzysztof Kozlowski
2023-03-12 9:32 ` [PATCH 5/5] arm64: dts: qcom: sdm845-shift-axolotl: update focaltech touchscreen properties Joel Selvaraj
2023-03-12 20:49 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62c20bd9-8f24-c226-1786-40bb20d95644@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alistair@alistair23.me \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=caleb@connolly.tech \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jdelvare@suse.de \
--cc=jeff@labundy.com \
--cc=job@noorman.info \
--cc=joelselvaraj.oss@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=markuss.broks@gmail.com \
--cc=max.krummenacher@toradex.com \
--cc=neil.armstrong@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).