From: Markus Elfring <Markus.Elfring@web.de>
To: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>,
linux-input@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH v3] HID: corsair-void: Add Corsair Void headset family driver
Date: Tue, 20 Aug 2024 11:16:51 +0200 [thread overview]
Message-ID: <64039307-fcfc-4e08-8727-c805964f7386@web.de> (raw)
In-Reply-To: <20240820002210.54014-3-stuart.a.hayhurst@gmail.com>
…
> +++ b/drivers/hid/hid-corsair-void.c
> @@ -0,0 +1,842 @@
…
> +static int corsair_void_set_sidetone_wireless(struct device *dev, const char *buf,
> + unsigned char sidetone)
> +{
…
> + int ret = 0;
…
> + ret = hid_hw_raw_request(hid_dev, CORSAIR_VOID_SIDETONE_REQUEST_ID,
> + send_buf, 12, HID_FEATURE_REPORT,
> + HID_REQ_SET_REPORT);
> +
> + return ret;
> +}
Would you like to return the value directly (without an intermediate local variable)?
Regards,
Markus
next prev parent reply other threads:[~2024-08-20 9:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 0:22 [PATCH v3] HID: corsair-void: Add Corsair Void headset family driver Stuart Hayhurst
2024-08-20 7:21 ` Markus Elfring
2024-08-20 17:59 ` Stuart
2024-08-21 6:49 ` [v3] " Markus Elfring
2024-08-20 9:16 ` Markus Elfring [this message]
2024-08-20 17:39 ` [PATCH v3] " Stuart
2024-08-21 7:50 ` Christophe JAILLET
2024-08-21 8:05 ` [v3] " Markus Elfring
2024-08-22 1:03 ` [PATCH v3] " Stuart
2024-08-22 6:02 ` Christophe JAILLET
2024-08-22 15:14 ` Stuart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64039307-fcfc-4e08-8727-c805964f7386@web.de \
--to=markus.elfring@web.de \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stuart.a.hayhurst@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).