From: "Torsten Kaiser" <just.for.lkml@googlemail.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Nick Sillik <n.sillik@temple.edu>,
David Brownell <david-b@pacbell.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
dmitry.torokhov@gmail.com, linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net
Subject: Re: [RFC: 2.6 patch] remove the USB_STORAGE_ONETOUCH driver
Date: Sun, 28 Oct 2007 19:48:03 +0200 [thread overview]
Message-ID: <64bb37e0710281048x589ab063o8a32294e30488979@mail.gmail.com> (raw)
In-Reply-To: <20071028155212.GC7227@stusta.de>
On 10/28/07, Adrian Bunk <bunk@kernel.org> wrote:
> Nearly two years ago, USB_STORAGE_ONETOUCH got a dependency on !PM.
> Considering that this also implies that the driver is not available
> e.g. when ACPI is enabled in the kernel that's not far from a dependency
> on BROKEN.
>
> This patch therefore removes this driver.
Hmm...
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c9d00fc148b210aa8cf388d6e1eac187a0e855a6
-> Adds !PM because suspend was broken (17.11.2005)
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7931e1c6f8007d5fef8a0bb2dc71bd97315eeae9
-> Adds suspend support, but fails to remove the !PM (5.12.2005)
So it looks like that !PM is false.
I have the following device:
Bus 001 Device 005: ID 1058:0400 Western Digital Technologies, Inc.
Bus 001 Device 004: ID 1058:0600 Western Digital Technologies, Inc.
Bus 001 Device 003: ID 1058:0500 Western Digital Technologies, Inc.
aka Western Digital Media Center
This firewire+usb hdd enclosure also has three buttons.
But it looks like that uses another driver:
hiddev0hidraw1: USB HID v1.10 Device [Western Digital External HDD] on
usb-0000:00:02.1-5.2
Otherwise I would be willing to try to test this, if someone would
tell me how to check that the second commit did fix the suspend
problem.
Torsten
next prev parent reply other threads:[~2007-10-28 17:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 15:52 [RFC: 2.6 patch] remove the USB_STORAGE_ONETOUCH driver Adrian Bunk
2007-10-28 17:48 ` Torsten Kaiser [this message]
2007-10-28 20:39 ` Jiri Kosina
2007-10-29 2:38 ` Dmitry Torokhov
2007-10-29 6:01 ` Torsten Kaiser
2007-10-29 14:22 ` Alan Stern
2007-10-29 14:28 ` [linux-usb-devel] " Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64bb37e0710281048x589ab063o8a32294e30488979@mail.gmail.com \
--to=just.for.lkml@googlemail.com \
--cc=bunk@kernel.org \
--cc=david-b@pacbell.net \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=n.sillik@temple.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox