From: Michael Schmitz <schmitzmic@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Michael Schmitz <schmitz@debian.org>,
Roman Zippel <zippel@linux-m68k.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning
Date: Thu, 27 May 2021 07:16:18 +1200 [thread overview]
Message-ID: <662f3b08-0f28-eda8-82a3-7d29b6474a47@gmail.com> (raw)
In-Reply-To: <20210526070345.31114-1-rdunlap@infradead.org>
Randy,
On 26/05/21 7:03 pm, Randy Dunlap wrote:
> MOUSE_ATARI should depend on INPUT_KEYBOARD since ATARI_KBD_CORE
> depends on INPUT_KEYBOARD. This prevents MOUSE_ATARI from
> selecting ATARI_KBD_CORE when INPUT_KEYBOARD is not set/enabled.
Right you are! Thanks for spotting this.
Reviewed-by: Michael Schmitz <schmitzmic@gmail.com>
>
> WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
> Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
> Selected by [y]:
> - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
>
> Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Michael Schmitz <schmitz@debian.org>
> Cc: Roman Zippel <zippel@linux-m68k.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> ---
> drivers/input/mouse/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210525.orig/drivers/input/mouse/Kconfig
> +++ linux-next-20210525/drivers/input/mouse/Kconfig
> @@ -348,6 +348,7 @@ config MOUSE_AMIGA
>
> config MOUSE_ATARI
> tristate "Atari mouse"
> + depends on INPUT_KEYBOARD
> depends on ATARI
> select ATARI_KBD_CORE
> help
prev parent reply other threads:[~2021-05-26 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 7:03 [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning Randy Dunlap
2021-05-26 7:20 ` Geert Uytterhoeven
2021-05-26 19:27 ` Michael Schmitz
2021-05-26 19:16 ` Michael Schmitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=662f3b08-0f28-eda8-82a3-7d29b6474a47@gmail.com \
--to=schmitzmic@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=schmitz@debian.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).