From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-b4-smtp.messagingengine.com (flow-b4-smtp.messagingengine.com [202.12.124.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD3163A782E; Fri, 22 May 2026 08:29:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779438566; cv=none; b=XMVDNsOFWMNGK/U+dUZbXzWLKM5NReDiqfpyl9jAuvDXeTQxquSeZvdz2y831CC6Rba8lH8NR73vJzcNk00sg72K8z90OFZN/vF4yNnkZZc1//zF2tq9pbqfa0ZOuUzyYakyC9XjwQpryvyzHUVrJ+x9fidYDw9thSjhJR9ry/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779438566; c=relaxed/simple; bh=S/W1IYFida+NA2QNwOCu8W2HVuY1ZiNPLNAJKV7ynfc=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=T8Ot1vGhQAXfuorkXLJ2Q07UZtq8oW+Zohhuw9QhOFbrYENlbc6pjOok5Ydgev/uT834dJilujrHukQYkYI/ghvLTz9+OafjLk3bWWtFajMXgRDsKvxOVnoPIpA5piA7ScOVV4GgC5LqCJ+S8UmF9RnWFpIqKuwOvj/UzZUfahE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=mVwc49J1; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=EUpK2Ma9; arc=none smtp.client-ip=202.12.124.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="mVwc49J1"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="EUpK2Ma9" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailflow.stl.internal (Postfix) with ESMTP id A289D1300C0A; Fri, 22 May 2026 04:29:21 -0400 (EDT) Received: from phl-imap-05 ([10.202.2.95]) by phl-compute-04.internal (MEProxy); Fri, 22 May 2026 04:29:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1779438561; x=1779445761; bh=K5cjv15MjjTF6ypOnMSrJMsfRdW4W+PPYBrqMoqvt/A=; b= mVwc49J1HBgWVrb4a/RQur0w8olfdgWprB68y5AQaHQKBXoXAw3WMCwEvlADbMZa woiU2CWyZVzvL2un+K4ZfXUVGVBgKvyaQ0waPfX2dovAGmipmnmch7wjsSyi/ggj ohAEcrvXX5Z0ybA87lR6nVxg8FUHxwcTSyOhBGWli/U5ZI3FFQHzJPoeA18Pj7tw WAaIfYhDuniH4wQYakbqBIqXipGGe7Q6iA/y8AH/jRUUp9jaJyz83OGlqauvsNRl rpMGWRSLrUqU7/F+jxwMoRP5CzwzEnViHkJJseLL5Q1bw4WbZj2UZdUWAHb3lRyb eisQnAsYJ9pqbcu6duBM7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1779438561; x= 1779445761; bh=K5cjv15MjjTF6ypOnMSrJMsfRdW4W+PPYBrqMoqvt/A=; b=E UpK2Ma9OrlBOcJrfk89xSalmv14z71Y742I7yR9JDliM14zAQQ2D0cod6aACcGDv or6qSJ5INamWzeACSQjuA5hI6ZLYdQEYo8D90K9A9ckq1h7ucOe4khbynAMoJmoU 2jZlm1NbFEdfiEHDaHOQ9dyPCyfontUTL2xT5bKY2J3W3JULBFjZyHFEzd8Ffd/x r2c+GRqVhLktgnWrOX0BdRygD96QKeVSyX+h3cT02YUnqR8yUGFgvP2rhzjiicPB iFTzxEAz1miglA2jKtOukdD4J0Ev0bzzJWVVWN0LXq2Bzp53I6Bdp/yeUz4MI2RH /uj8Y5FZdiY/g20nRwOZA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddugeelkeegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehrnhgu uceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrthhtvg hrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefggfevudegudevledvkefhvdei necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnh gusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepgedtpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopegsphesrghlihgvnhekrdguvgdprhgtphhtthhopehtshgsohhgvg hnugesrghlphhhrgdrfhhrrghnkhgvnhdruggvpdhrtghpthhtohepthhonhihsegrthho mhhiuggvrdgtohhmpdhrtghpthhtohepkhhhihhlmhgrnhessggrhihlihgsrhgvrdgtoh hmpdhrtghpthhtohepfhhlohhrihgrnhdrfhgrihhnvghllhhisegsrhhorggutghomhdr tghomhdprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpth htohepughmihhtrhihrdhtohhrohhkhhhovhesghhmrghilhdrtghomhdprhgtphhtthho pehjohhnrghsrdhgohhrshhkihesghhmrghilhdrtghomhdprhgtphhtthhopehmrgiiii hivghsrggttghouhhnthesghhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 708B7182007A; Fri, 22 May 2026 04:29:19 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: ArrYli9DFPON Date: Fri, 22 May 2026 10:28:59 +0200 From: "Arnd Bergmann" To: "Matti Vaittinen" , "Arnd Bergmann" , "open list:GPIO SUBSYSTEM" Cc: linux-kernel@vger.kernel.org, "Christian Lamparter" , "Johannes Berg" , "Aaro Koskinen" , "Andreas Kemnade" , "Kevin Hilman" , "Roger Quadros" , "Tony Lindgren" , "Thomas Bogendoerfer" , "John Paul Adrian Glaubitz" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , x86@kernel.org, "H. Peter Anvin" , "Linus Walleij" , "Bartosz Golaszewski" , "Dmitry Torokhov" , "Lee Jones" , "Pavel Machek" , "Florian Fainelli" , "Jonas Gorski" , "Andrew Lunn" , "Vladimir Oltean" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , linux-wireless@vger.kernel.org, Linux-OMAP , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-sh@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, Netdev Message-Id: <681f328c-bc8a-4410-b876-f8c5f116325d@app.fastmail.com> In-Reply-To: References: <20260520183815.2510387-1-arnd@kernel.org> <20260520183815.2510387-3-arnd@kernel.org> Subject: Re: [PATCH 02/10] [v3] input: gpio-keys: make legacy gpiolib optional Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, May 22, 2026, at 06:55, Matti Vaittinen wrote: > On 20/05/2026 21:38, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> The two Rohm PMIC drivers use a gpio-keys device without an actual GPIO, >> passing an IRQ number instead. In order to keep this working both with >> and with CONFIG_GPIOLIB_LEGACY, change the gpio-keys driver to ignore >> the gpio number if an IRQ is passed. >> > > I am (still) all fine with this, even though I like Dmitry's set. I > suppose you already have a plan for merging this, but I still have to > ask - why the MFD changes aren't in own patch? I feel it would have > simplified merging, backporting, reviewing and reverting if needed. Splitting it out would break bisection: The gpio-leds change without the mfd change causes a build failure when assigning the .gpio field, and the reverse causes a runtime failure when .gpio=0 is a valid line. It would be possible to only do the gpio-led driver patch without the header file change first. This would let us apply the last patch in the series without regression, but it would risk having not catching other drivers that incorrectly set the .gpio field while CONFIG_GPIOLIB_LEGACY is disabled. Arnd