From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47649C4332F for ; Tue, 13 Dec 2022 16:14:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235974AbiLMQOO convert rfc822-to-8bit (ORCPT ); Tue, 13 Dec 2022 11:14:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236008AbiLMQOM (ORCPT ); Tue, 13 Dec 2022 11:14:12 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 371061CFCC; Tue, 13 Dec 2022 08:14:10 -0800 (PST) Received: (Authenticated sender: hadess@hadess.net) by mail.gandi.net (Postfix) with ESMTPSA id 5469260002; Tue, 13 Dec 2022 16:14:07 +0000 (UTC) Message-ID: <6b5e878265958fb0201178fc3c1d75ef06c826ec.camel@hadess.net> Subject: Re: [Regression] Logitech BT mouse unusable after commit 532223c8ac57 (still in 6.1-rc8) From: Bastien Nocera To: "Rafael J. Wysocki" Cc: Jiri Kosina , Filipe =?ISO-8859-1?Q?La=EDns?= , Benjamin Tissoires , linux-input@vger.kernel.org, LKML , Thorsten Leemhuis Date: Tue, 13 Dec 2022 17:14:06 +0100 In-Reply-To: References: <2262737.ElGaqSPkdT@kreacher> <1df12728a2e788788fd387588bac62023e123d16.camel@hadess.net> <2145955.irdbgypaU6@kreacher> <8281ddcc16cc950f9cde4b196cf208adcc798319.camel@hadess.net> <91367d07a72ecb2065faebe974c54ebd966e0d59.camel@hadess.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, 2022-12-08 at 16:20 +0100, Bastien Nocera wrote: > On Wed, 2022-12-07 at 18:44 +0100, Rafael J. Wysocki wrote: > > On Wed, Dec 7, 2022 at 6:19 PM Bastien Nocera > > wrote: > > > > > > On Wed, 2022-12-07 at 12:07 +0100, Rafael J. Wysocki wrote: > > > > # hidpp-list-features /dev/hidraw1 > > > > Bluetooth Mouse M336/M337/M535 (046d:b016) is a HID++ 4.5 > > > > device > > > > Feature 0x01: [0x0001] Feature set > > > > Feature 0x02: [0x0003] Device FW version > > > > Feature 0x03: [0x0005] Device name > > > > Feature 0x04: [0x0020] Reset > > > > Feature 0x05: [0x1e00] Enable hidden features (hidden) > > > > Feature 0x06: [0x1800] Generic Test (hidden, internal) > > > > Feature 0x07: [0x1000] Battery status > > > > Feature 0x08: [0x1b04] Reprog controls v4 > > > > Feature 0x09: [0x2100] Vertical scrolling > > > > Feature 0x0a: [0x2200] Mouse pointer > > > > Feature 0x0b: [0x2205] Pointer speed > > > > Feature 0x0c: [0x18b1] ? (hidden, internal) > > > > Feature 0x0d: [0x2121] Hi-res wheel > > > > Feature 0x0e: [0x1f03] ? (hidden, internal) > > > > > > Would you be able to enable debugging for the hid subsystem to > > > get > > > some > > > debug data when getting the version from the device fails? > > > > I guess I could, but I think that the device is just quirky. > > > > At least the BT layer appears to think that it is connected. > > > > Anyway, what exactly do you need? > > > > > I can't see any problems in there that wouldn't also have > > > impacted > > > all > > > the other Logitech Bluetooth devices listed in the support > > > devices > > > list. > > > > > > If the problem is a timeout, maybe we should lower the timeouts > > > we > > > currently have (5*HZ = 5 seconds, right?), so we can retry 5 > > > times > > > one > > > second instead. > > > > No, it doesn't take 5 sec to get a response from it.  It rather > > looks > > like __hidpp_send_report() returns an error. > > Adding "debug" on the kernel command-line should be enough to get > debug > out of hidpp_send_message_sync(): > https://stackoverflow.com/a/63682160 > > Either that or turn all the dbg_hid() into hid_err() if you're going > to > be compiling the kernel. > > We're mainly interested in the error code from the device, as that's > what I'm guessing is caused the error to propagate. Can you also check whether you had: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?id=8b7e58409b1813c58eea542d9f3b8db35b4ac1f7 in your git tree? Would be great to know whether that commit helps at all. Cheers > > > Still, as I mentioned earlier, I can't reproduce the problem on > > > another > > > Bluetooth Classic device... >