From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Eric Gonçalves" <ghatto404@gmail.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Henrik Rydberg" <rydberg@bitmath.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] dt-bindings: input: add ST-Microelectronics FTS2BA61Y touchscreen binding
Date: Sun, 14 Sep 2025 16:48:49 +0200 [thread overview]
Message-ID: <716da762-3aa8-4c39-b9fe-8e923b20a0d5@kernel.org> (raw)
In-Reply-To: <20250911211910.45903-2-ghatto404@gmail.com>
On 11/09/2025 23:19, Eric Gonçalves wrote:
> Add the bindings for ST-Microelectronics FTS2BA61Y capacitive touchscreen.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> +
> +properties:
> + compatible:
> + const: st,fts2ba61y
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + avdd-supply: true
> + vdd-supply: true
> +
> +unevaluatedProperties: false
This goes after required: field.
Other than that - why isn't this finished (non RFC)? Code looks ok, but
I also did not look that thorough.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-14 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 21:19 [RFC PATCH 0/2] Input: add fts2ba61y touchscreen driver Eric Gonçalves
2025-09-11 21:19 ` [RFC PATCH 1/2] dt-bindings: input: add ST-Microelectronics FTS2BA61Y touchscreen binding Eric Gonçalves
2025-09-14 14:48 ` Krzysztof Kozlowski [this message]
2025-09-14 16:16 ` Eric Gonçalves
2025-09-14 16:46 ` Krzysztof Kozlowski
2025-09-11 21:19 ` [RFC PATCH 2/2] Input: add support for the STM FTS2BA61Y touchscreen Eric Gonçalves
2025-09-14 14:47 ` [RFC PATCH 0/2] Input: add fts2ba61y touchscreen driver Krzysztof Kozlowski
2025-09-14 14:53 ` Ivaylo Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=716da762-3aa8-4c39-b9fe-8e923b20a0d5@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ghatto404@gmail.com \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).