From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FE55C433E4 for ; Thu, 23 Jul 2020 20:50:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 751A622B43 for ; Thu, 23 Jul 2020 20:50:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RMdgF5LZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726146AbgGWUur (ORCPT ); Thu, 23 Jul 2020 16:50:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbgGWUur (ORCPT ); Thu, 23 Jul 2020 16:50:47 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54483C0619D3; Thu, 23 Jul 2020 13:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=hcFSk1zoqynrqfpyHJjn5KFl4stE+TWu+6kpqiKw4a8=; b=RMdgF5LZBJN+Q2JKXhCdwoq6MI lHC2E3mTeJpYN2Rfp8vqlq3CcjjTW9w9Lqa+Mex9mY+cL4F/NDFHzeEhHeJXM53PAmFrJhRDT+B2Z ZAV1n5cL9QhDIDkhTF3bs5a2lqKwOaNF51TGkgwc+S+f6B3lpqafkpoelpakn/LyMiovcEe1s8DF3 vSLSnsO6oEbN/O0K2TTKBRPrQiWrNevficXi1Wu+Lny4ZAyKHDpBJCugQFc6DicufZU6gQ9/xRADX FutwXcbei2/Os6/NIExZMVOZ1Dm8BxC6wZ81ZTXfjme13xhewn6hIOZjqXXbAwwAIY2oFu7bw343r DbwQaxyA==; Received: from [2601:1c0:6280:3f0::19c2] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyiAs-0003r8-ML; Thu, 23 Jul 2020 20:50:43 +0000 Subject: Re: [PATCH V17 3/3] Input: new da7280 haptic driver To: Roy Im , Uwe Kleine-Koenig , Bartosz Golaszewski , Brian Masney , Dmitry Torokhov , Greg KH , Lee Jones , Luca Weiss , Maximilian Luz , Pascal PAILLET-LME , Rob Herring , Samuel Ortiz , Thierry Reding , Thomas Gleixner Cc: Support Opensource , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org References: From: Randy Dunlap Message-ID: <71818ab8-0020-77db-c412-8d35a541ead3@infradead.org> Date: Thu, 23 Jul 2020 13:50:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 7/23/20 8:01 AM, Roy Im wrote: > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig > index 362e8a0..06dc5a3 100644 > --- a/drivers/input/misc/Kconfig > +++ b/drivers/input/misc/Kconfig > @@ -869,4 +869,17 @@ config INPUT_STPMIC1_ONKEY > To compile this driver as a module, choose M here: the > module will be called stpmic1_onkey. > > +config INPUT_DA7280_HAPTICS > + tristate "Dialog Semiconductor DA7280 haptics support" > + depends on INPUT && I2C > + select INPUT_FF_MEMLESS > + select REGMAP_I2C > + help > + Say Y to enable support for the Dialog DA7280 haptics driver. > + The haptics can be controlled by I2C communication, > + or by PWM input, or by GPI. Is that GPIO. ? Can the haptics be controlled only by PWM or only by GPI(O)? Just curious: why is I2C required to build the driver if a user is only controlling the device by PWM or GPI? > + > + To compile this driver as a module, choose M here: the > + module will be called da7280. > + > endif thanks. -- ~Randy