From: Corentin Chary <corentin.chary@gmail.com>
To: Yong Wang <yong.y.wang@linux.intel.com>
Cc: cascardo@holoscopio.com, Matthew Garrett <mjg59@srcf.ucam.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] eeepc-wmi: new driver for WMI based hotkeys on Eee PC laptops
Date: Sat, 20 Mar 2010 18:21:42 +0100 [thread overview]
Message-ID: <71cd59b01003201021q118500a9nc1f56b37803d5bf3@mail.gmail.com> (raw)
In-Reply-To: <20100320122416.GA10558@ywang-moblin2.bj.intel.com>
>> You should either use backlight_force_update in your driver or let the
>> user update it writing to the brightness file. In your case, I'd say you
>> should use backlight_force_update and give BACKLIGHT_UPDATE_HOTKEY as
>> the reason.
>>
>
> Oh, I see. Thank for clarifying, Cascardo.
>
> -Yong
>
Hi Yong,
You can check how eeepc-laptop work for backlight stuff.
I think you should also remove all the NOTIFY_BRNDOWN_* code. It's
still in eeepc-laptop for backward compatibility, but it should not be
i newer drivers.
Anyway, most of the time the backlight will be handled by the
acpi/video.ko driver which will
send events itself.
I will update this page soon
http://dev.iksaif.net/projects/acpi4asus/wiki/Eeepc-wmi .
Do you want this driver to be part of acpi4asus project ? It would
allow to share the same git tree / bugtracker / wiki. I can give you
access to all that stuff quickly. I think it would be easier for users
if we merge into one single project.
Thanks for you work.
--
Corentin Chary
http://xf.iksaif.net
next prev parent reply other threads:[~2010-03-20 17:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100319133924.GA30427@ywang-moblin2.bj.intel.com>
2010-03-19 13:59 ` [PATCH] eeepc-wmi: new driver for WMI based hotkeys on Eee PC laptops Matthew Garrett
2010-03-19 15:10 ` Yong Wang
2010-03-19 15:23 ` Matthew Garrett
2010-03-19 15:21 ` Yong Wang
2010-03-20 0:55 ` Yong Wang
2010-03-20 12:20 ` cascardo
2010-03-20 12:24 ` Yong Wang
2010-03-20 17:21 ` Corentin Chary [this message]
2010-03-21 0:59 ` Yong Wang
2010-03-21 13:14 ` Corentin Chary
2010-03-21 13:35 ` Yong Wang
2010-03-21 13:55 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71cd59b01003201021q118500a9nc1f56b37803d5bf3@mail.gmail.com \
--to=corentin.chary@gmail.com \
--cc=cascardo@holoscopio.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yong.y.wang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).