linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Weikang Guo <guoweikang.kernel@gmail.com>
Cc: Bastien Nocera <hadess@hadess.net>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [QUESTION] Plans for GDIX1003 Support in Goodix Touchscreen Driver
Date: Sat, 1 Mar 2025 12:36:40 +0100	[thread overview]
Message-ID: <72619870-bf83-47f9-9b66-6678e245364c@redhat.com> (raw)
In-Reply-To: <CAOm6qnmYSQz_YVaWw1c-fMm3NCVV9MoQhLQ0XGzK9o2RybLHmw@mail.gmail.com>

Hi WeiKang,

On 27-Feb-25 12:36 PM, Weikang Guo wrote:
> Hi, Hans
> 
> On Tue, 25 Feb 2025 at 20:09, Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Hi WeiKang,
>>
>> On 25-Feb-25 3:04 AM, Weikang Guo wrote:
>>> Hi Bastien, Hans, Dmitry,
>>>
>>> I am currently working on the Ayaneo Flip DS device, which I installed Kali
>>> Linux with kernel version 6.8.11-amd. This device has two touchscreens,
>>> but only one is functional. After investigating, I found that the second
>>> touchscreen has the device ID GDIX1003(confirmed by exporting the results
>>> through acpidump), and upon comparing with the current driver, I noticed
>>> that only GDIX1001, GDIX1002, and GDX9110 are supported.
>>>
>>> I have also reviewed the ACPI description and can provide the details if
>>> needed. Any guidance or updates on this would be greatly appreciated.
>>
>> I think this might just work with the existing goodix driver, just
>> add the new GDIX1003 HID to the goodix_acpi_match table:
>>
>> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
>> index a3e8a51c9144..4b497540ed2d 100644
>> --- a/drivers/input/touchscreen/goodix.c
>> +++ b/drivers/input/touchscreen/goodix.c
>> @@ -1519,6 +1519,7 @@ MODULE_DEVICE_TABLE(i2c, goodix_ts_id);
>>  static const struct acpi_device_id goodix_acpi_match[] = {
>>         { "GDIX1001", 0 },
>>         { "GDIX1002", 0 },
>> +       { "GDIX1003", 0 },
>>         { "GDX9110", 0 },
>>         { }
>>  };
>>
>> Note I'm not sure this will work, but is worth a try.
>>
> 
> It works, thank you very much.

Thank you for testing.

I've submitted a patch upstream to add this new hardware-ID
to the kernel:

https://lore.kernel.org/linux-input/20250301113525.6997-1-hdegoede@redhat.com/

Regards,

Hans




  reply	other threads:[~2025-03-01 11:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAOm6qnnhR9++REgtjhZpqNXkBbBAZsGAY8Oy89cXUF9S=Vy-9Q@mail.gmail.com>
2025-02-25  6:04 ` [QUESTION] Plans for GDIX1003 Support in Goodix Touchscreen Driver Dmitry Torokhov
2025-02-25 12:09 ` Hans de Goede
2025-02-27 11:36   ` Weikang Guo
2025-03-01 11:36     ` Hans de Goede [this message]
2025-02-25  2:44 Weikang Guo
  -- strict thread matches above, loose matches on Subject: below --
2025-02-25  2:44 Weikang Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72619870-bf83-47f9-9b66-6678e245364c@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=guoweikang.kernel@gmail.com \
    --cc=hadess@hadess.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).