Fwd: ThinkPad L540: suspend not working (deep / S3 / standby, regression Linux 4.19 -> 6.1)

Fwd: ThinkPad L540: suspend not working (deep / S3 / standby, regression Linux 4.19 -> 6.1)

[Bagas Sanjaya]

Hi,

I notice a regression report on Bugzilla [1]. Quoting from it:

> ThinkPad L540 failed suspend deep dmesg output - Linux-6.1.27 from Debian-12
> 
> Since updating from Linux-4.19 to Linux-6.1.27 suspend deep is not working anymore.
> (a.k.a. S3, standby or suspend to ram)
> 
> Notebook: ThinkPad L540 20AU-S00N00
> OS: Debian-12 "Bookworm" (was Debian-10 "Buster" before)
> Kernel: Linux-6.1.27 from Debian-12 (was Linux-4.19 from Debian-10 before)
> 
> Can I provide any other helpful information?
> Do you need a test with a vanilla Linux-6.1 kernel?
> Should I perform any other tests or maybe try out boot parameters?
> 
> Full dmesg output attached.
> Excerpt:
> rmi4_f01 rmi4-00.fn01: Failed to write sleep mode: -6.
> rmi4_f01 rmi4-00.fn01: Suspend failed with code -6.
> rmi4_physical rmi4-00: Failed to suspend functions: -6
> rmi4_smbus 0-002c: Failed to suspend device: -6
> rmi4_smbus 0-002c: PM: dpm_run_callback(): rmi_smb_suspend+0x0/0x40 [rmi_smbus] returns -6
> rmi4_smbus 0-002c: PM: failed to suspend async: error -6
> sd 4:0:0:0: [sda] Synchronizing SCSI cache
> sd 4:0:0:0: [sda] Stopping disk
> PM: Some devices failed to suspend, or early wake event detected
> sd 4:0:0:0: [sda] Starting disk
> OOM killer enabled.
> Restarting tasks ... 
> rmi4_physical rmi4-00: rmi_driver_set_irq_bits: Failed to change enabled interrupts!
> psmouse: probe of serio2 failed with error -1
> 
> 
> 
> Maybe related:
> 
> 5.17-rc regression: X1 Carbon touchpad not resumed
> https://lore.kernel.org/lkml/YgF%2F0QGFN4SppLKg@shikoro/T/

FYI, I guess the regression is also introduced by 172d931910e1db
("i2c: enable async suspend/resume on i2c client devices") and
should have been fixed by 7b1f781f2d2460 ("Input: psmouse - set up
dependency between PS/2 and SMBus companions"), but it doesn't
fix the reporter's issue.

Anyway, I'm adding this to regzbot:

#regzbot introduced: v4.19..v6.1 https://bugzilla.kernel.org/show_bug.cgi?id=217462
#regzbot title: psmouse suspend failed on ThinkPad L540

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=217462

-- 
An old man doll... just what I always wanted! - Clara

Re: Fwd: ThinkPad L540: suspend not working (deep / S3 / standby, regression Linux 4.19 -> 6.1)

[Hans de Goede]

Hi All,

This looks like something for Benjamin Tissoires (who will
be available to look at this in 2 weeks or so) to look at.

Adding Benjamin to the Cc.

In the mean time passing psmouse.synaptics_intertouch=0 on the
kernel commandline should restore the old 4.19 kernel behavior
of simply using the touchpad in ps/2 mode.

Regards,

Hans



On 5/19/23 15:19, Bagas Sanjaya wrote:
> Hi,
> 
> I notice a regression report on Bugzilla [1]. Quoting from it:
> 
>> ThinkPad L540 failed suspend deep dmesg output - Linux-6.1.27 from Debian-12
>>
>> Since updating from Linux-4.19 to Linux-6.1.27 suspend deep is not working anymore.
>> (a.k.a. S3, standby or suspend to ram)
>>
>> Notebook: ThinkPad L540 20AU-S00N00
>> OS: Debian-12 "Bookworm" (was Debian-10 "Buster" before)
>> Kernel: Linux-6.1.27 from Debian-12 (was Linux-4.19 from Debian-10 before)
>>
>> Can I provide any other helpful information?
>> Do you need a test with a vanilla Linux-6.1 kernel?
>> Should I perform any other tests or maybe try out boot parameters?
>>
>> Full dmesg output attached.
>> Excerpt:
>> rmi4_f01 rmi4-00.fn01: Failed to write sleep mode: -6.
>> rmi4_f01 rmi4-00.fn01: Suspend failed with code -6.
>> rmi4_physical rmi4-00: Failed to suspend functions: -6
>> rmi4_smbus 0-002c: Failed to suspend device: -6
>> rmi4_smbus 0-002c: PM: dpm_run_callback(): rmi_smb_suspend+0x0/0x40 [rmi_smbus] returns -6
>> rmi4_smbus 0-002c: PM: failed to suspend async: error -6
>> sd 4:0:0:0: [sda] Synchronizing SCSI cache
>> sd 4:0:0:0: [sda] Stopping disk
>> PM: Some devices failed to suspend, or early wake event detected
>> sd 4:0:0:0: [sda] Starting disk
>> OOM killer enabled.
>> Restarting tasks ... 
>> rmi4_physical rmi4-00: rmi_driver_set_irq_bits: Failed to change enabled interrupts!
>> psmouse: probe of serio2 failed with error -1
>>
>>
>>
>> Maybe related:
>>
>> 5.17-rc regression: X1 Carbon touchpad not resumed
>> https://lore.kernel.org/lkml/YgF%2F0QGFN4SppLKg@shikoro/T/
> 
> FYI, I guess the regression is also introduced by 172d931910e1db
> ("i2c: enable async suspend/resume on i2c client devices") and
> should have been fixed by 7b1f781f2d2460 ("Input: psmouse - set up
> dependency between PS/2 and SMBus companions"), but it doesn't
> fix the reporter's issue.
> 
> Anyway, I'm adding this to regzbot:
> 
> #regzbot introduced: v4.19..v6.1 https://bugzilla.kernel.org/show_bug.cgi?id=217462
> #regzbot title: psmouse suspend failed on ThinkPad L540
> 
> Thanks.
> 
> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217462
> 

Re: Fwd: ThinkPad L540: suspend not working (deep / S3 / standby, regression Linux 4.19 -> 6.1)

[Bagas Sanjaya]

On 5/19/23 20:46, Hans de Goede wrote:
> Hi All,
> 
> This looks like something for Benjamin Tissoires (who will
> be available to look at this in 2 weeks or so) to look at.
> 
> Adding Benjamin to the Cc.
> 
> In the mean time passing psmouse.synaptics_intertouch=0 on the
> kernel commandline should restore the old 4.19 kernel behavior
> of simply using the touchpad in ps/2 mode.
> 

OK, thanks!

-- 
An old man doll... just what I always wanted! - Clara

Re: Fwd: ThinkPad L540: suspend not working (deep / S3 / standby, regression Linux 4.19 -> 6.1)

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

On Fri, May 19, 2023 at 08:19:39PM +0700, Bagas Sanjaya wrote:
> #regzbot introduced: v4.19..v6.1 https://bugzilla.kernel.org/show_bug.cgi?id=217462
> #regzbot title: psmouse suspend failed on ThinkPad L540
> 

The reporter had narrowed down possible culprit commit range [1],
thus telling regzbot:

#regzbot introduced: v5.16.18..v5.17-rc3

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=217462#c3

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]