Re: [PATCH,RFC] Input: gpio-keys - request and configure GPIOs

["pHilipp Zabel" <philipp.zabel@gmail.com>]

On Nov 16, 2007 2:38 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> Hi,
>
> On Nov 16, 2007 6:33 AM, Herbert Valerio Riedel <hvr@gnu.org> wrote:
> > Currently, gpio_keys.c assumes the GPIOs to be already properly configured;
> > this patch changes gpio-keys to perform explicit calls to gpio_request() and
> > gpio_configure_input().
> >
> > This matches the behaviour of leds-gpio.
> >
>
> Makes sense from where I sit but let's see what guys who actually use
> the module say... ;)

Looks good to me, too. I have yet to test, but at least the gpio_direction call
is mandatory as per gpio api docs, so this fixes an actual bug.
gpio_request is optional and claims the GPIO for this driver's use
only (on architectures where
this is supported), so I'm not sure if this is really needed, but it
shouldn't harm any of the current users of gpio-keys.

regards
Philipp