From mboxrd@z Thu Jan 1 00:00:00 1970 From: "pHilipp Zabel" Subject: Re: [PATCH,RFC] Input: gpio-keys - request and configure GPIOs Date: Fri, 16 Nov 2007 15:19:58 +0100 Message-ID: <74d0deb30711160619s2e4acd2ex31238dad34a6ae6d@mail.gmail.com> References: <1195212830-9137-1-git-send-email-hvr@gnu.org> <1195222151.10848.47.camel@pbook.intra> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from fk-out-0910.google.com ([209.85.128.191]:39674 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758849AbXKPOUF (ORCPT ); Fri, 16 Nov 2007 09:20:05 -0500 Received: by fk-out-0910.google.com with SMTP id z23so890724fkz for ; Fri, 16 Nov 2007 06:20:03 -0800 (PST) In-Reply-To: <1195222151.10848.47.camel@pbook.intra> Content-Disposition: inline Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Herbert Valerio Riedel Cc: Dmitry Torokhov , linux-input@vger.kernel.org, Paul Sokolovsky , Philip Blundell On Nov 16, 2007 3:09 PM, Herbert Valerio Riedel wrote: > > > On Fri, 2007-11-16 at 08:38 -0500, Dmitry Torokhov wrote: > > On Nov 16, 2007 6:33 AM, Herbert Valerio Riedel wrote: > > > Currently, gpio_keys.c assumes the GPIOs to be already properly configured; > > > this patch changes gpio-keys to perform explicit calls to gpio_request() and > > > gpio_configure_input(). > > > > > > This matches the behaviour of leds-gpio. > > > Makes sense from where I sit but let's see what guys who actually use > > the module say... ;) > > I grepped through my 2.6.24-git source tre, and the only places I found > gpio_keys.h included was > > drivers/input/keyboard/gpio_keys.c:#include > arch/arm/mach-orion/dns323-setup.c:#include > arch/arm/mach-at91/board-sam9261ek.c:#include > > with dn323-setup.c being maintained by myself, and board-sam9261ek.c > having seemingly non-compilable code wrt to gpio_keys (for instance, it > uses ".keycode" gpio_keys_button struct members which should have been > ".code"), there don't seem to exist many users of that module...? :-) We have quite a big number of users in the handhelds.org CVS kernel tree. Unfortunately we are traditionally slow at pushing things to mainline, and many of the devices depend on something like gpiolib hitting mainline for their GPIO extenders. regards Philipp