[PATCH] Input: Enable WM97xx touchscreen sub-drivers by default

[PATCH] Input: Enable WM97xx touchscreen sub-drivers by default

[Mark Brown]

Currently the support for each WM97xx touchscreen model is compiled out
by default, meaning that the default configuration when the driver is
built is for it to support no hardware.  This is suboptimal and leads to
problems like distribution kernels shipping a non-functional driver.

Change the default to support all controllers and update the help text
to reflect this.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/input/touchscreen/Kconfig |   21 +++++++++------------
 1 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index e573665..f3933f0 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -237,29 +237,26 @@ config TOUCHSCREEN_WM97XX
 config TOUCHSCREEN_WM9705
 	bool "WM9705 Touchscreen interface support"
 	depends on TOUCHSCREEN_WM97XX
+	default y
 	help
-	  Say Y here if you have a Wolfson Microelectronics WM9705
-	  touchscreen controller connected to your system.
-
-	  If unsure, say N.
+	  Say Y here if to enable support for the Wolfson Microelectronics
+	  WM9705 touchscreen controller.
 
 config TOUCHSCREEN_WM9712
 	bool "WM9712 Touchscreen interface support"
 	depends on TOUCHSCREEN_WM97XX
+	default y
 	help
-	  Say Y here if you have a Wolfson Microelectronics WM9712
-	  touchscreen controller connected to your system.
-
-	  If unsure, say N.
+	  Say Y here if to enable support for the Wolfson Microelectronics
+	  WM9712 touchscreen controller.
 
 config TOUCHSCREEN_WM9713
 	bool "WM9713 Touchscreen interface support"
 	depends on TOUCHSCREEN_WM97XX
+	default y
 	help
-	  Say Y here if you have a Wolfson Microelectronics WM9713 touchscreen
-	  controller connected to your system.
-
-	  If unsure, say N.
+	  Say Y here if to enable support for the Wolfson Microelectronics
+	  WM9713 touchscreen controller.
 
 config TOUCHSCREEN_WM97XX_MAINSTONE
 	tristate "WM97xx Mainstone accelerated touch"
-- 
1.5.6.3

[PATCH] Input: Enable WM97xx touchscreen sub-drivers by default

[Mark Brown]

Currently the support for each WM97xx touchscreen model is compiled out
by default, meaning that the default configuration when the driver is
built is for it to support no hardware.  This is suboptimal and leads to
problems like distribution kernels shipping a non-functional driver.

Change the default to support all controllers and update the help text
to reflect this.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---

Resubmit, after proofreading.

 drivers/input/touchscreen/Kconfig |   21 +++++++++------------
 1 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index e573665..7606120 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -237,29 +237,26 @@ config TOUCHSCREEN_WM97XX
 config TOUCHSCREEN_WM9705
 	bool "WM9705 Touchscreen interface support"
 	depends on TOUCHSCREEN_WM97XX
+	default y
 	help
-	  Say Y here if you have a Wolfson Microelectronics WM9705
-	  touchscreen controller connected to your system.
-
-	  If unsure, say N.
+	  Say Y here to enable support for the Wolfson Microelectronics
+	  WM9705 touchscreen controller.
 
 config TOUCHSCREEN_WM9712
 	bool "WM9712 Touchscreen interface support"
 	depends on TOUCHSCREEN_WM97XX
+	default y
 	help
-	  Say Y here if you have a Wolfson Microelectronics WM9712
-	  touchscreen controller connected to your system.
-
-	  If unsure, say N.
+	  Say Y here to enable support for the Wolfson Microelectronics
+	  WM9712 touchscreen controller.
 
 config TOUCHSCREEN_WM9713
 	bool "WM9713 Touchscreen interface support"
 	depends on TOUCHSCREEN_WM97XX
+	default y
 	help
-	  Say Y here if you have a Wolfson Microelectronics WM9713 touchscreen
-	  controller connected to your system.
-
-	  If unsure, say N.
+	  Say Y here to enable support for the Wolfson Microelectronics
+	  WM9713 touchscreen controller.
 
 config TOUCHSCREEN_WM97XX_MAINSTONE
 	tristate "WM97xx Mainstone accelerated touch"
-- 
1.5.6.3

Re: [PATCH] Input: Enable WM97xx touchscreen sub-drivers by default

[Arjan van de Ven]

On Thu, 24 Jul 2008 14:41:07 +0100
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> Currently the support for each WM97xx touchscreen model is compiled
> out by default, meaning that the default configuration when the
> driver is built is for it to support no hardware.  This is suboptimal
> and leads to problems like distribution kernels shipping a
> non-functional driver.


this isn't normally how things are done; Linux is on a "off unless
selected or unless it breaks booting" policy nowadays...

(and distributions don't follow "default" anyway, so don't worry about
that part)

-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

Re: [PATCH] Input: Enable WM97xx touchscreen sub-drivers by default

[Mark Brown]

On Thu, Jul 24, 2008 at 06:57:56AM -0700, Arjan van de Ven wrote:
> Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> 
> > Currently the support for each WM97xx touchscreen model is compiled
> > out by default, meaning that the default configuration when the

> this isn't normally how things are done; Linux is on a "off unless
> selected or unless it breaks booting" policy nowadays...

These options only be visible if the user has chosen to build the WM97xx
touchscreen driver which does the default thing already.  Within the
context of the driver these options are of the broken boot variety since
without at least one of them being enabled the driver will do nothing
except waste resources.

I really don't think it's sensible for the default configuration of the
driver to produce something totally non-functional.

> (and distributions don't follow "default" anyway, so don't worry about
> that part)

This change is a direct result of Ubuntu enabling the driver with all
the controllers compiled out.  This seems like a completely reasonable
thing for them to do - nothing in Kconfig suggests that it is mandatory
to enable at least one of the options and the existing default and help
text both suggest that it should be turned off.

Re: [PATCH] Input: Enable WM97xx touchscreen sub-drivers by default

[Dmitry Torokhov]

On Thu, Jul 24, 2008 at 03:26:51PM +0100, Mark Brown wrote:
> On Thu, Jul 24, 2008 at 06:57:56AM -0700, Arjan van de Ven wrote:
> > Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> > 
> > > Currently the support for each WM97xx touchscreen model is compiled
> > > out by default, meaning that the default configuration when the
> 
> > this isn't normally how things are done; Linux is on a "off unless
> > selected or unless it breaks booting" policy nowadays...
> 
> These options only be visible if the user has chosen to build the WM97xx
> touchscreen driver which does the default thing already.  Within the
> context of the driver these options are of the broken boot variety since
> without at least one of them being enabled the driver will do nothing
> except waste resources.
> 
> I really don't think it's sensible for the default configuration of the
> driver to produce something totally non-functional.
> 
> > (and distributions don't follow "default" anyway, so don't worry about
> > that part)
> 
> This change is a direct result of Ubuntu enabling the driver with all
> the controllers compiled out.  This seems like a completely reasonable
> thing for them to do - nothing in Kconfig suggests that it is mandatory
> to enable at least one of the options and the existing default and help
> text both suggest that it should be turned off.

I agree with Mark - since the core driver is disabled by default we
don't burden users who do not want it. However enabling the main
option should produce working driver and people who want to save space
in their custom kernels can disable unneeded sub-options.

Will apply.

-- 
Dmitry

Re: [PATCH] Input: Enable WM97xx touchscreen sub-drivers by default

[pHilipp Zabel]

On Thu, Jul 24, 2008 at 3:15 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> Currently the support for each WM97xx touchscreen model is compiled out
> by default, meaning that the default configuration when the driver is
> built is for it to support no hardware.  This is suboptimal and leads to
> problems like distribution kernels shipping a non-functional driver.
>
> Change the default to support all controllers and update the help text
> to reflect this.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  drivers/input/touchscreen/Kconfig |   21 +++++++++------------
>  1 files changed, 9 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index e573665..f3933f0 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -237,29 +237,26 @@ config TOUCHSCREEN_WM97XX
>  config TOUCHSCREEN_WM9705
>        bool "WM9705 Touchscreen interface support"
>        depends on TOUCHSCREEN_WM97XX
> +       default y
>        help
> -         Say Y here if you have a Wolfson Microelectronics WM9705
> -         touchscreen controller connected to your system.
> -
> -         If unsure, say N.
> +         Say Y here if to enable support for the Wolfson Microelectronics

Say Y here to enable?

> +         WM9705 touchscreen controller.
>
>  config TOUCHSCREEN_WM9712
>        bool "WM9712 Touchscreen interface support"
>        depends on TOUCHSCREEN_WM97XX
> +       default y
>        help
> -         Say Y here if you have a Wolfson Microelectronics WM9712
> -         touchscreen controller connected to your system.
> -
> -         If unsure, say N.
> +         Say Y here if to enable support for the Wolfson Microelectronics

dito

> +         WM9712 touchscreen controller.
>
>  config TOUCHSCREEN_WM9713
>        bool "WM9713 Touchscreen interface support"
>        depends on TOUCHSCREEN_WM97XX
> +       default y
>        help
> -         Say Y here if you have a Wolfson Microelectronics WM9713 touchscreen
> -         controller connected to your system.
> -
> -         If unsure, say N.
> +         Say Y here if to enable support for the Wolfson Microelectronics

dito

> +         WM9713 touchscreen controller.
>
>  config TOUCHSCREEN_WM97XX_MAINSTONE
>        tristate "WM97xx Mainstone accelerated touch"
> --
> 1.5.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

regards
Philipp