From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BDA2C433B4 for ; Thu, 22 Apr 2021 16:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 226BC613B8 for ; Thu, 22 Apr 2021 16:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236662AbhDVQdM (ORCPT ); Thu, 22 Apr 2021 12:33:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237972AbhDVQdI (ORCPT ); Thu, 22 Apr 2021 12:33:08 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14B42C06174A; Thu, 22 Apr 2021 09:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject: Sender:Reply-To:Content-ID:Content-Description; bh=HBW9pi1AtwAKNZXHGCpKKjsedA+rzUKisGIAxuDRPPE=; b=KPw58ASa5uatO+OME3CXuHpLgP fO2sTkNeWLtDXLbD0fyJZm8OxTjbxJjjBBy5Ed1OPurDQrwSjaKjh0F2ZwsTI0YUbbadhQbwKWgqf IL5nAwmi8tLxwgZtYq5aWPOIh4tCEGVkpwpr+XOVOyNXdKJ7lpDn1SUqFw+2HIQUqN2zL/OIh9aPS fSuu+f+82Wf4XmxD6OspvX/fOpWhhNP3l1wVI/VAA2D8HwgmuUtcXH424UU+kkzRgSHHgfRn5r7IF a5E+yguRdBE5GPwqDHNG7Ys5uij5+qiGUDn/8ewV5W9dQ+bgHNjS5qYzxS9zZsLUR7btA0nU3Jn7R 1NQln+Mg==; Received: from [2601:1c0:6280:3f0::df68] by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lZcFj-00H5cH-CO; Thu, 22 Apr 2021 16:32:31 +0000 Subject: Re: [PATCH] Input: rework USB Kconfig dependencies To: Arnd Bergmann , Dmitry Torokhov Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210422133647.1877425-1-arnd@kernel.org> From: Randy Dunlap Message-ID: <74e04402-58b3-b1e5-4f72-9fe227f21b35@infradead.org> Date: Thu, 22 Apr 2021 09:32:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210422133647.1877425-1-arnd@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 4/22/21 6:36 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > A lot of input drivers traditionally depend on CONFIG_USB_ARCH_HAS_HCD > and select CONFIG_USB. This works but is different from almost every > other subsystem in the kernel. > > I found this when debugging a build failure in the RC subsystem that > had the same logic. > > The problem here is that CONFIG_USB_ARCH_HAS_HCD no longer has > a meaning since the host controller support has been changed to > use machine specific loadable modules for the USB host. Selecting > a subsystem that a driver needs is confusing and can lead to > recursive dependency chains in Kconfig. > > In both cases, the normal logic is to specify 'depends on USB'. > > Signed-off-by: Arnd Bergmann Reviewed-by: Randy Dunlap Thanks. > --- > drivers/input/joystick/Kconfig | 6 ++---- > drivers/input/misc/Kconfig | 15 +++++---------- > drivers/input/mouse/Kconfig | 9 +++------ > drivers/input/tablet/Kconfig | 15 +++++---------- > drivers/input/touchscreen/Kconfig | 3 +-- > 5 files changed, 16 insertions(+), 32 deletions(-) > -- ~Randy