From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9CF0C4332F for ; Tue, 31 Oct 2023 12:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344309AbjJaMsz (ORCPT ); Tue, 31 Oct 2023 08:48:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344349AbjJaMsw (ORCPT ); Tue, 31 Oct 2023 08:48:52 -0400 X-Greylist: delayed 576 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 31 Oct 2023 05:48:49 PDT Received: from 12.mo584.mail-out.ovh.net (12.mo584.mail-out.ovh.net [178.33.104.253]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0555FC2 for ; Tue, 31 Oct 2023 05:48:48 -0700 (PDT) Received: from director6.ghost.mail-out.ovh.net (unknown [10.109.146.122]) by mo584.mail-out.ovh.net (Postfix) with ESMTP id 9A0E1244BD for ; Tue, 31 Oct 2023 12:39:10 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-ccsb6 (unknown [10.110.103.253]) by director6.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 45CA71FD23; Tue, 31 Oct 2023 12:39:10 +0000 (UTC) Received: from RCM-web9.webmail.mail.ovh.net ([151.80.29.21]) by ghost-submission-6684bf9d7b-ccsb6 with ESMTPSA id oaz+C271QGXitwAArYvRAA (envelope-from ); Tue, 31 Oct 2023 12:39:10 +0000 MIME-Version: 1.0 Date: Tue, 31 Oct 2023 14:39:09 +0200 From: =?UTF-8?Q?Jos=C3=A9_Pekkarinen?= To: dmitry.torokhov@gmail.com, rydberg@bitmath.org, skhan@linuxfoundation.org Cc: rrangel@chromium.org, amandhoot12@gmail.com, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-input@vger.kernel.org Subject: Re: [PATCH] Input: synaptics: enable InterTouch for ThinkPad L14 G1 In-Reply-To: <5d857ff972e9203ef65ae2396c7285c0@foxhound.fi> References: <20231008080129.17931-1-jose.pekkarinen@foxhound.fi> <5d857ff972e9203ef65ae2396c7285c0@foxhound.fi> User-Agent: Roundcube Webmail/1.4.15 Message-ID: <77a53e59cc4151c95942f37c88db8c75@foxhound.fi> X-Sender: jose.pekkarinen@foxhound.fi Organization: Foxhound Ltd. X-Originating-IP: 192.42.116.198 X-Webmail-UserID: jose.pekkarinen@foxhound.fi Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 17685072787369993833 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedruddtvddggeduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpeggfffhvfevufgjfhgfkfigohhitgfgsehtkehjtddtreejnecuhfhrohhmpeflohhsrocurfgvkhhkrghrihhnvghnuceojhhoshgvrdhpvghkkhgrrhhinhgvnhesfhhogihhohhunhgurdhfiheqnecuggftrfgrthhtvghrnhepjeduhefhveffueevfeejueeljeegvedtgffhheelffekjeeuteffkeethfekteejnecuffhomhgrihhnpehlihhnuhigfhhouhhnuggrthhiohhnrdhorhhgnecukfhppeduvdejrddtrddtrddupdduledvrdegvddrudduiedrudelkedpudehuddrkedtrddvledrvddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeojhhoshgvrdhpvghkkhgrrhhinhgvnhesfhhogihhohhunhgurdhfiheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqihhnphhuthesvhhgvghrrdhkvghrnhgvlhdrohhrghdpoffvtefjohhsthepmhhoheekgedpmhhouggvpehsmhhtphhouhht Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 2023-10-16 18:51, José Pekkarinen wrote: > On 2023-10-08 11:01, José Pekkarinen wrote: >> Observed on dmesg of my laptop I see the following >> output: >> >> [ 19.898700] psmouse serio1: synaptics: queried max coordinates: x >> [..5678], y [..4694] >> [ 19.936057] psmouse serio1: synaptics: queried min coordinates: x >> [1266..], y [1162..] >> [ 19.936076] psmouse serio1: synaptics: Your touchpad (PNP: LEN0411 >> PNP0f13) says it can support a different bus. If i2c-hid and hid-rmi >> are not used, you might want to try setting >> psmouse.synaptics_intertouch to 1 and report this to >> linux-input@vger.kernel.org. >> [ 20.008901] psmouse serio1: synaptics: Touchpad model: 1, fw: >> 10.32, id: 0x1e2a1, caps: 0xf014a3/0x940300/0x12e800/0x500000, board >> id: 3471, fw id: 2909640 >> [ 20.008925] psmouse serio1: synaptics: serio: Synaptics >> pass-through port at isa0060/serio1/input0 >> [ 20.053344] input: SynPS/2 Synaptics TouchPad as >> /devices/platform/i8042/serio1/input/input7 >> [ 20.397608] mousedev: PS/2 mouse device common for all mice >> >> This patch will add its pnp id to the smbus list to >> produce the setup of intertouch for the device. After >> applying, the ouput will look like: >> >> [ 19.168664] psmouse serio1: synaptics: queried max coordinates: x >> [..5678], y [..4694] >> [ 19.206311] psmouse serio1: synaptics: queried min coordinates: x >> [1266..], y [1162..] >> [ 19.206325] psmouse serio1: synaptics: Trying to set up SMBus >> access >> [ 19.209545] psmouse serio1: synaptics: SMbus companion is not ready >> yet >> [ 19.283845] psmouse serio1: synaptics: Touchpad model: 1, fw: >> 10.32, id: 0x1e2a1, caps: 0xf014a3/0x940300/0x12e800/0x500000, board >> id: 3471, fw id: 2909640 >> [ 19.283863] psmouse serio1: synaptics: serio: Synaptics >> pass-through port at isa0060/serio1/input0 >> [ 19.328959] input: SynPS/2 Synaptics TouchPad as >> /devices/platform/i8042/serio1/input/input8 >> [ 19.706164] mousedev: PS/2 mouse device common for all mice >> >> Signed-off-by: José Pekkarinen >> --- >> drivers/input/mouse/synaptics.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/input/mouse/synaptics.c >> b/drivers/input/mouse/synaptics.c >> index ada299ec5bba..376a041c80b2 100644 >> --- a/drivers/input/mouse/synaptics.c >> +++ b/drivers/input/mouse/synaptics.c >> @@ -183,6 +183,7 @@ static const char * const smbus_pnp_ids[] = { >> "LEN009b", /* T580 */ >> "LEN0402", /* X1 Extreme Gen 2 / P1 Gen 2 */ >> "LEN040f", /* P1 Gen 3 */ >> + "LEN0411", /* L14 Gen 1 */ >> "LEN200f", /* T450s */ >> "LEN2044", /* L470 */ >> "LEN2054", /* E480 */ > > Any comments here? > > Thanks! > > José. > _______________________________________________ > Linux-kernel-mentees mailing list > Linux-kernel-mentees@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees Ping. José.