From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C2E2CE7A89 for ; Sat, 23 Sep 2023 08:28:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230491AbjIWI2J (ORCPT ); Sat, 23 Sep 2023 04:28:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230490AbjIWI2G (ORCPT ); Sat, 23 Sep 2023 04:28:06 -0400 Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F35B7CCA for ; Sat, 23 Sep 2023 01:27:59 -0700 (PDT) Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTP id jm11qEfEKez0CjxzDqArPu; Sat, 23 Sep 2023 08:27:35 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id jxzaqH9UeyzmHjxzaqbOYX; Sat, 23 Sep 2023 08:27:59 +0000 X-Authority-Analysis: v=2.4 cv=BuOOfKb5 c=1 sm=1 tr=0 ts=650ea18f a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=P7XfKmiOJ4/qXqHZrN7ymg==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=pGLkceISAAAA:8 a=VwQbUJbxAAAA:8 a=cm27Pg_UAAAA:8 a=gjWtsrhGNCPogvnVG7wA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Qe3KtCAORllSc14uOo/VkMifAxQFSeyAwgdtm9iTt24=; b=uypdy4HdLrWH7g0O+iDdmWgFef rLTVGONvlnSK/K+3/gKna+eG4wN+yDjXss0TJyUI7xwgYHljzHJLU3lM4RDL+XKMuzbtIZfypIil5 rXJrinelPx3/e4gpcMu38oWPmNJLjBL8FAx/z4u2eYn7KkmaG8+Mzfurm4eCAceU0YqKvs2ZRY9L/ DZFzybUHDD7NC8AnmSdI7906UH2pvsbMA19IRwULduHT1Z9SYil+9QfN97SRXfiwlxOpQwex7OMec zx+8Qb2I/0bwjZedHJV20p3LAv7Et1RvCuoDH43L6Jd8t3ZfZjWZrxoIX3xiAVLqNRMobU5y3S0ON D9EJudNA==; Received: from [94.239.20.48] (port=34534 helo=[192.168.1.98]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qjxzZ-003XRR-2V; Sat, 23 Sep 2023 03:27:57 -0500 Message-ID: <781aa943-29de-2992-e68f-1bc062a3f4fe@embeddedor.com> Date: Sat, 23 Sep 2023 10:29:03 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] input: Annotate struct evdev_client with __counted_by Content-Language: en-US To: Kees Cook , Dmitry Torokhov Cc: linux-input@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230922175027.work.563-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230922175027.work.563-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 94.239.20.48 X-Source-L: No X-Exim-ID: 1qjxzZ-003XRR-2V X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.98]) [94.239.20.48]:34534 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 84 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEX+F6r+55WNQ9tDZk05KRFCRV92dLy5uVVjt+M4AUGvMNC0waws85QNNrn51Tk2tTza8UykkLBWCNCD+QvrrWxKqa9PHftJztD7202jUpPghouZYLI2 SFbSc6WH9tmHKrr/G9z7LcfodragWKcdJLA6qxU/cDUnkmxnEwCO2BVZrb40RRWedUgB1jVYMhSMe0fHgtQsoJigV4dEM2onuJSOodPiyH8yBOpDp6E5viQ8 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 9/22/23 11:50, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct evdev_client. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Dmitry Torokhov > Cc: linux-input@vger.kernel.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/input/evdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c > index 95f90699d2b1..51e0c4954600 100644 > --- a/drivers/input/evdev.c > +++ b/drivers/input/evdev.c > @@ -50,7 +50,7 @@ struct evdev_client { > bool revoked; > unsigned long *evmasks[EV_CNT]; > unsigned int bufsize; > - struct input_event buffer[]; > + struct input_event buffer[] __counted_by(bufsize); > }; > > static size_t evdev_get_mask_cnt(unsigned int type)