Re: hid-pidff bug: fails to find all required reports of saitek gamepad

[Dmitriy Geels <dmitriy.geels@gmail.com>]

Hello!

My decision to replace usb_unlink_urb() with usb_kill_urb() was wrong.
After fixing usbhid->urbctrl initialization I got kernel crashes
again, and according to logs, it was crashing inside irq handling.
I changed that line back to usb_unlink_urb() and got working driver.

I found out reason of device/driver hangs: device doesn't like inplace
effect updates (for any changes effect should be deleted and
reuploaded). Inplace changes also work, but device becomes stuck after
closing and doesn't play anything from ffmvforce anymore until
reconnected.

This describes, why windows driver resets device on each open (report
52 01). Also windows driver sends enable/disable actuators on device
open/close.

Actually, it would be good to do reset and enable actuators on device
open and disable actuators on close, but that will break access of
several applications to one device.