* [PATCH] drivers/input/touchscreen/goodix.c: Add support for ACPI ID GDX9110
@ 2023-08-07 12:47 Felix Engelhardt
2023-08-07 17:08 ` Hans de Goede
2023-08-15 18:39 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Felix Engelhardt @ 2023-08-07 12:47 UTC (permalink / raw)
Cc: Felix Engelhardt, Bastien Nocera, Hans de Goede, Dmitry Torokhov,
linux-input, linux-kernel
The Goodix touchscreen controller with ACPI ID GDX9110 was not recognized
by the goodix driver. This patch adds this ID to the list of supported IDs,
allowing the driver to be used with this device. The change will allow
Linux to be used on ~1 million tablet devices used in Kenyan primary
schools.
Signed-off-by: Felix Engelhardt <felix.engelhardt@eidu.com>
---
drivers/input/touchscreen/goodix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 4f53d3c57e69..9cdc01eb00c9 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -1379,6 +1379,7 @@ MODULE_DEVICE_TABLE(i2c, goodix_ts_id);
static const struct acpi_device_id goodix_acpi_match[] = {
{ "GDIX1001", 0 },
{ "GDIX1002", 0 },
+ { "GDX9110", 0 },
{ }
};
MODULE_DEVICE_TABLE(acpi, goodix_acpi_match);
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/input/touchscreen/goodix.c: Add support for ACPI ID GDX9110
2023-08-07 12:47 [PATCH] drivers/input/touchscreen/goodix.c: Add support for ACPI ID GDX9110 Felix Engelhardt
@ 2023-08-07 17:08 ` Hans de Goede
2023-08-15 18:39 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2023-08-07 17:08 UTC (permalink / raw)
To: Felix Engelhardt
Cc: Bastien Nocera, Dmitry Torokhov, linux-input, linux-kernel
Hi,
On 8/7/23 14:47, Felix Engelhardt wrote:
> The Goodix touchscreen controller with ACPI ID GDX9110 was not recognized
> by the goodix driver. This patch adds this ID to the list of supported IDs,
> allowing the driver to be used with this device. The change will allow
> Linux to be used on ~1 million tablet devices used in Kenyan primary
> schools.
>
> Signed-off-by: Felix Engelhardt <felix.engelhardt@eidu.com>
> ---
> drivers/input/touchscreen/goodix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> index 4f53d3c57e69..9cdc01eb00c9 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -1379,6 +1379,7 @@ MODULE_DEVICE_TABLE(i2c, goodix_ts_id);
> static const struct acpi_device_id goodix_acpi_match[] = {
> { "GDIX1001", 0 },
> { "GDIX1002", 0 },
> + { "GDX9110", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(acpi, goodix_acpi_match);
Hmm, GDX without the 'I' does look like an official ACPI vendor prefix. But if this is used in the wild, then I guess we'll just need to live with it:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/input/touchscreen/goodix.c: Add support for ACPI ID GDX9110
2023-08-07 12:47 [PATCH] drivers/input/touchscreen/goodix.c: Add support for ACPI ID GDX9110 Felix Engelhardt
2023-08-07 17:08 ` Hans de Goede
@ 2023-08-15 18:39 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2023-08-15 18:39 UTC (permalink / raw)
To: Felix Engelhardt; +Cc: Bastien Nocera, Hans de Goede, linux-input, linux-kernel
On Mon, Aug 07, 2023 at 02:47:23PM +0200, Felix Engelhardt wrote:
> The Goodix touchscreen controller with ACPI ID GDX9110 was not recognized
> by the goodix driver. This patch adds this ID to the list of supported IDs,
> allowing the driver to be used with this device. The change will allow
> Linux to be used on ~1 million tablet devices used in Kenyan primary
> schools.
>
> Signed-off-by: Felix Engelhardt <felix.engelhardt@eidu.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-15 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-07 12:47 [PATCH] drivers/input/touchscreen/goodix.c: Add support for ACPI ID GDX9110 Felix Engelhardt
2023-08-07 17:08 ` Hans de Goede
2023-08-15 18:39 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).