linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v2 2/3] dt-bindings: input: Add bindings for TouchNetix axiom touchscreen
@ 2023-10-10  7:15 kamel.bouhara
  0 siblings, 0 replies; 3+ messages in thread
From: kamel.bouhara @ 2023-10-10  7:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Henrik Rydberg, linux-input, linux-kernel, devicetree,
	mark.satterthwaite, pedro.torruella, bartp, hannah.rossiter,
	Thomas Petazzoni, Gregory Clement, bsp-development.geo

Hello Krzysztof,

Le 2023-10-09 17:05, Krzysztof Kozlowski a écrit :
> On 09/10/2023 15:44, Kamel Bouhara wrote:
>> Add the TouchNetix axiom I2C touchscreen device tree bindings
>> documentation.
> 
> A nit, subject: drop second/last, redundant "bindings for". The
> "dt-bindings" prefix is already stating that these are bindings.
> 

OK.

>> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
>> ---
>>  .../touchscreen/touchnetix,axiom-ax54a.yaml   | 51 
>> +++++++++++++++++++
>>  MAINTAINERS                                   |  6 +++
>>  2 files changed, 57 insertions(+)
>>  create mode 100644 
>> Documentation/devicetree/bindings/input/touchscreen/touchnetix,axiom-ax54a.yaml
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/input/touchscreen/touchnetix,axiom-ax54a.yaml 
>> b/Documentation/devicetree/bindings/input/touchscreen/touchnetix,axiom-ax54a.yaml
>> new file mode 100644
>> index 000000000000..41201d7112a6
>> --- /dev/null
>> +++ 
>> b/Documentation/devicetree/bindings/input/touchscreen/touchnetix,axiom-ax54a.yaml
>> @@ -0,0 +1,51 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: 
>> http://devicetree.org/schemas/input/touchscreen/touchnetix,axiom-ax54a.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: TouchNetix Axiom series touchscreen controller
>> +
>> +maintainers:
>> +  - Kamel Bouhara <kamel.bouhara@bootlin.com>
>> +
>> +properties:
>> +  compatible:
>> +    const: touchnetix,axiom-ax54a
>> +
>> +  reg:
>> +    const: 0x66
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  irq-gpios:
>> +    maxItems: 1
> 
> Why these are GPIOs? Interrupts are usually just interrupts... You need
> to clearly describe this.
> 

I've been using this for some specific acpi stuff hence it need to be 
removed.

> 
>> +
>> +  reset-gpios:
>> +    maxItems: 1
>> +
>> +additionalProperties: false
> 
> This goes after required: block.
> 
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/gpio/gpio.h>
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +    i2c {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +      axiom@66 {
> 
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 

Ack.

> 
> 
>> +        compatible = "touchnetix,axiom-ax54a";
>> +        reg = <0x66>;
>> +        interrupt-parent = <&gpio2>;
>> +        interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
>> +        irq-gpios = <&gpio2 0 GPIO_ACTIVE_LOW>;
> 
> Eh? This looks really wrong.

OK let's clean that as well.

Thanks

> 
> 
> Best regards,
> Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH v2 0/3] Input: Add TouchNetix aXiom touchscreen driver
@ 2023-10-09 13:44 Kamel Bouhara
  2023-10-09 13:44 ` [PATCH v2 2/3] dt-bindings: input: Add bindings for TouchNetix axiom touchscreen Kamel Bouhara
  0 siblings, 1 reply; 3+ messages in thread
From: Kamel Bouhara @ 2023-10-09 13:44 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Henrik Rydberg
  Cc: linux-input, linux-kernel, devicetree, mark.satterthwaite,
	pedro.torruella, bartp, hannah.rossiter, Thomas Petazzoni,
	Gregory Clement, bsp-development.geo, Kamel Bouhara

Add a new driver for the TouchNetix's aXiom family of
touchscreen controller. This driver only support i2c
and can be later adapted for SPI and USB support.

---
Changes in v2:
 - Add device tree binding documentation
 - Move core functions in axiom_i2c as we only care about i2c support now
 - Use static function when required
 - Use syntax dev_err_probe()
 - Add an hardware based reset

Kamel Bouhara (3):
  dt-bindings: vendor-prefixes: Add TouchNetix AS
  dt-bindings: input: Add bindings for TouchNetix axiom touchscreen
  Input: Add TouchNetix aXiom i2c touchscreen driver

 .../touchscreen/touchnetix,axiom_ax54a.yaml   |  52 ++
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 MAINTAINERS                                   |   6 +
 drivers/input/touchscreen/Kconfig             |  13 +
 drivers/input/touchscreen/Makefile            |   1 +
 .../input/touchscreen/touchnetix_axiom_i2c.c  | 751 ++++++++++++++++++
 6 files changed, 825 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/touchnetix,axiom_ax54a.yaml
 create mode 100644 drivers/input/touchscreen/touchnetix_axiom_i2c.c

-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-10  7:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-10  7:15 [PATCH v2 2/3] dt-bindings: input: Add bindings for TouchNetix axiom touchscreen kamel.bouhara
  -- strict thread matches above, loose matches on Subject: below --
2023-10-09 13:44 [PATCH v2 0/3] Input: Add TouchNetix aXiom touchscreen driver Kamel Bouhara
2023-10-09 13:44 ` [PATCH v2 2/3] dt-bindings: input: Add bindings for TouchNetix axiom touchscreen Kamel Bouhara
2023-10-09 15:05   ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).